Skip to content

[18.0][MIG] sale_timesheet_rounded #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MVillaescusaM wants to merge 20 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] sale_timesheet_rounded #849

MVillaescusaM wants to merge 20 commits into from

Conversation

@MVillaescusaM
Copy link

@MVillaescusaM MVillaescusaM commented Nov 27, 2025

No description provided.

simahawk and others added 19 commits November 27, 2025 13:47
@simahawk @MVillaescusaM
Add sale_timesheet_rounded
70359dc 
sale_timesheet_rounded: fix do not use default
@MVillaescusaM
[IMP] sale_timesheet_rounded: black, isort, prettier
a9178e1
@MVillaescusaM
[MIG] sale_timesheet_rounded: Migration to 13.0
a8b81a0
@pedrobaeza @MVillaescusaM
[IMP] sale_timesheet_rounded: Convert it to computed writeable
c8e8afb 
This way, we avoid a lot of code and get the same features.
@fshah-initos @MVillaescusaM
[IMP] sale_timesheet_rounded: black, isort, prettier
2e2df16
@fshah-initos @MVillaescusaM
[14.0][MIG]sale_timesheet_rounded
90c5b46
@enriquemartin @MVillaescusaM
12.0 - sale_timesheet_rounded
61e5608 
fixes issue OCA#687
@OCA-git-bot @MVillaescusaM
sale_timesheet_rounded 14.0.1.0.1
1241168
@MVillaescusaM
[FIX] sale_timesheet_round: test need an install decorator
b374dc6
@MVillaescusaM
[15.0] MIG sale_timesheet_rounding: Migration to 15.0
cc3ec5a
@MVillaescusaM
[15.0] MIG sale_timesheet_rounding: Fixing precommit error
df62a6d
@MVillaescusaM
[15.0][FIX] sale_timesheet_rounded: avoid recomputing rounded amounts…
fa8b465 
… when posting an invoice
@hoangphuc1410 @MVillaescusaM
[16.0][MIG] sale_timesheet_rounded: Migration to 16.0
817cab3
@MVillaescusaM
[IMP] sale_timesheet_rounded: pre-commit auto fixes
a9de264
@MVillaescusaM
[MIG] sale_timesheet_rounded: Migration to 17.0
ba0bfee
@MVillaescusaM
[UPD] Update sale_timesheet_rounded.pot
f1f93e4
@weblate @MVillaescusaM
Update translation files
071c6f5 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: timesheet-17.0/timesheet-17.0-sale_timesheet_rounded
Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-sale_timesheet_rounded/
@mymage @MVillaescusaM
Translated using Weblate (Italian)
1f586e0 
Currently translated at 100.0% (21 of 21 strings)

Translation: timesheet-17.0/timesheet-17.0-sale_timesheet_rounded
Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-sale_timesheet_rounded/it/
@mymage @MVillaescusaM
Translated using Weblate (Italian)
7b70f26 
Currently translated at 100.0% (21 of 21 strings)

Translation: timesheet-17.0/timesheet-17.0-sale_timesheet_rounded
Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-sale_timesheet_rounded/it/
@MVillaescusaM MVillaescusaM changed the title [18.0] [MIG] sale_timesheetrounded [18.0][MIG] sale_timesheet_rounded Nov 27, 2025
@MVillaescusaM
Copy link
Author

MVillaescusaM commented Nov 27, 2025

@flachica

@MVillaescusaM
Copy link
Author

MVillaescusaM commented Nov 27, 2025

@dgarcia-tf @Mcastillol14

@ivs-cetmix
Copy link
Member

ivs-cetmix commented Dec 11, 2025

Hi @MVillaescusaM, thank you for your contribution! Could you please check and fix the tests?

@flachica
Copy link

flachica commented Jan 22, 2026

@MVillaescusaM ¿Resolvemos esto ASAP?

@ivs-cetmix
Copy link
Member

ivs-cetmix commented Jan 23, 2026

Hi @MVillaescusaM , thank you very much! Could you please check he codecove report and add some minor test(s) so we could have codecove green as well?

@MVillaescusaM
Copy link
Author

MVillaescusaM commented Jan 23, 2026

Hi @ivs-cetmix , done! All in green!

@ivs-cetmix
Copy link
Member

ivs-cetmix commented Jan 23, 2026

Great job, thank you @MVillaescusaM !

@ivs-cetmix
Copy link
Member

ivs-cetmix commented Jan 23, 2026

@flachica would appreciate your review!

@flachica
Copy link

flachica commented Jan 26, 2026

@MVillaescusaM If you configure a rounding method to adjust the units to 15 minutes, for example, I get the following error:

File "/opt/odoo/src/addons/oca/timesheet/sale_timesheet_rounded/models/account_analytic_line.py", line 51, in _calc_rounded_amount
unit_amount_rounded = float_round(
File "/opt/odoo/src/odoo/odoo/tools/float_utils.py", line 122, in float_round
raise ValueError(msg)
ValueError: unknown rounding method: HALF_UP

Also, make sure your commit history follows OCA guidelines. I currently see many commits in your branch after the message "[MIG] sale_timesheet_rounded: Migration to 18.0"

@ivs-cetmix
Copy link
Member

ivs-cetmix commented Feb 4, 2026

Hi @MVillaescusaM thank thank you for the update, please ping @flachica as soon as the commit history is fixed.

@MVillaescusaM MVillaescusaM force-pushed the 18.0-mig-sale_timesheet_rounded branch from 142bae8 to 0821b04 Compare February 4, 2026 09:36
@MVillaescusaM
Copy link
Author

MVillaescusaM commented Feb 4, 2026

@flachica ready to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.