-
-
Notifications
You must be signed in to change notification settings - Fork 392
[18.0][MIG] hr_timesheet_name_customer: migration from 16.0 #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] hr_timesheet_name_customer: migration from 16.0 #850
Conversation
|
How about reactivating this migration to 17.0 first and base it on this? #773 |
|
Hi @CRogos , thank you for your feedback! Unfortunately we don't have real project on 17.0 to test this module on. However we can migrate it to 18.0 and back port it to 17.0 afterwards. |
ivs-cetmix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mohajiro you must preserve the commit history
db72d35 to
749f89a
Compare
This module added new field Customer Description in list view In this module in report pdf instead of Description you can see Customer Description. This field can see only Timesheets:Administrator
749f89a to
90d5e65
Compare
|
@ivs-cetmix thank you, it's done. |
Currently translated at 100.0% (7 of 7 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_name_customer Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_name_customer/es/
Currently translated at 100.0% (7 of 7 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_name_customer Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_name_customer/pt_BR/
Currently translated at 100.0% (7 of 7 strings) Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_name_customer Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_name_customer/fr/
Before this commit, the creation would fail when no 'name' value was provided.
Show "Description Customer" in portal instead of "Description". This is done to maintain consistency and show the same information in all views and reports. Otherwise a client can be confused by seeing different descriptions in reports and portal. Add a post-init hook to populate "Description Customer" with "Description" for existing records if it is not set. This is done to ensure that the "Description Customer" field is not empty.
Standard migration from 16.0 to 18.0.
90d5e65 to
5f8634a
Compare
ivs-cetmix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
Hide 'Description' for correct UX. Task: 5140
7fcbb13 to
c56b6a9
Compare
Aldeigja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional LGTM
|
This PR has the |
|
Hey @OCA/project-service-maintainers let's start the new year with some migration PRs merged 🎉 |
|
/ocabot migration hr_timesheet_name_customer |
|
Sorry @leemannd you are not allowed to mark the addon to be migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
|
@ivs-cetmix You pinged the wrong team. IDK which team is leading this repository. |
Thank you anyway! Let's try @OCA/human-resources-maintainers 😄 |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Hey @dreispt , looks like the ocabot is still on vacations or was simply drunk yesterday. Should we ping someone technical to wake him up? 🤔 |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at ca2d3ad. Thanks a lot for contributing to OCA. ❤️ |
Standard migration from 16.0 to 18.0.