Skip to content

Conversation

@Mohajiro
Copy link
Contributor

@Mohajiro Mohajiro commented Dec 11, 2025

Standard migration from 16.0 to 18.0.

@CRogos
Copy link
Contributor

CRogos commented Dec 12, 2025

How about reactivating this migration to 17.0 first and base it on this? #773

@ivs-cetmix
Copy link
Member

Hi @CRogos , thank you for your feedback! Unfortunately we don't have real project on 17.0 to test this module on. However we can migrate it to 18.0 and back port it to 17.0 afterwards.

Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mohajiro you must preserve the commit history

@Mohajiro Mohajiro force-pushed the 18.0-mig-hr_timesheet_name_customer branch from db72d35 to 749f89a Compare December 20, 2025 16:43
OCA-git-bot and others added 2 commits December 20, 2025 17:46
This module added new field Customer Description in list view
In this module in report pdf instead of Description you can see Customer
Description. This field can see only Timesheets:Administrator
@Mohajiro Mohajiro force-pushed the 18.0-mig-hr_timesheet_name_customer branch from 749f89a to 90d5e65 Compare December 20, 2025 16:52
@Mohajiro
Copy link
Contributor Author

@ivs-cetmix thank you, it's done.

Ivorra78 and others added 6 commits December 20, 2025 19:26
Currently translated at 100.0% (7 of 7 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_name_customer
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_name_customer/es/
Currently translated at 100.0% (7 of 7 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_name_customer
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_name_customer/pt_BR/
Currently translated at 100.0% (7 of 7 strings)

Translation: timesheet-16.0/timesheet-16.0-hr_timesheet_name_customer
Translate-URL: https://translation.odoo-community.org/projects/timesheet-16-0/timesheet-16-0-hr_timesheet_name_customer/fr/
Before this commit, the creation would fail when no 'name' value was provided.
Show "Description Customer" in portal instead of "Description".
This is done to maintain consistency and show the same information
in all views and reports.
Otherwise a client can be confused by seeing different descriptions in
reports and portal.

Add a post-init hook to populate "Description Customer" with "Description"
for existing records if it is not set.
This is done to ensure that the "Description Customer" field is not empty.
Standard migration from 16.0 to 18.0.
@Mohajiro Mohajiro force-pushed the 18.0-mig-hr_timesheet_name_customer branch from 90d5e65 to 5f8634a Compare December 20, 2025 18:26
Copy link
Member

@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

Hide 'Description' for correct UX.

Task: 5140
@Mohajiro Mohajiro force-pushed the 18.0-mig-hr_timesheet_name_customer branch from 7fcbb13 to c56b6a9 Compare December 23, 2025 17:23
Copy link

@Aldeigja Aldeigja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@ivs-cetmix
Copy link
Member

Hey @OCA/project-service-maintainers let's start the new year with some migration PRs merged 🎉

@leemannd
Copy link

leemannd commented Jan 5, 2026

/ocabot migration hr_timesheet_name_customer

@OCA-git-bot
Copy link
Contributor

Sorry @leemannd you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@leemannd
Copy link

leemannd commented Jan 5, 2026

@ivs-cetmix You pinged the wrong team. IDK which team is leading this repository.

@ivs-cetmix
Copy link
Member

@ivs-cetmix You pinged the wrong team. IDK which team is leading this repository.

Thank you anyway! Let's try @OCA/human-resources-maintainers 😄
Let's start the new year with some migration PRs merged 🎉

@dreispt
Copy link
Member

dreispt commented Jan 6, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-850-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 6, 2026
Signed-off-by dreispt
@ivs-cetmix
Copy link
Member

Hey @dreispt , looks like the ocabot is still on vacations or was simply drunk yesterday. Should we ping someone technical to wake him up? 🤔

@ivs-cetmix
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-850-by-ivs-cetmix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9c6e800 into OCA:18.0 Jan 26, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ca2d3ad. Thanks a lot for contributing to OCA. ❤️

@ivs-cetmix ivs-cetmix deleted the 18.0-mig-hr_timesheet_name_customer branch January 26, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.