Skip to content

[19.0][MIG] website_membership: Migration to 19.0 - #226

Merged
OCA-git-bot merged 6 commits into
OCA:19.0from
Tecnativa:19.0-mig-website_membership
Jul 28, 2026
Merged

[19.0][MIG] website_membership: Migration to 19.0#226
OCA-git-bot merged 6 commits into
OCA:19.0from
Tecnativa:19.0-mig-website_membership

Conversation

@victoralmau

@victoralmau victoralmau commented Jun 26, 2026

Copy link
Copy Markdown
Member

@OCA-git-bot OCA-git-bot added series:19.0 mod:website_membership Module website_membership labels Jun 26, 2026
@victoralmau
victoralmau force-pushed the 19.0-mig-website_membership branch from 547377d to 47d2602 Compare June 26, 2026 06:59
@pilarvargas-tecnativa
pilarvargas-tecnativa force-pushed the 19.0-mig-website_membership branch 2 times, most recently from aa8cf41 to 7c3ffd4 Compare June 26, 2026 10:56
@victoralmau
victoralmau force-pushed the 19.0-mig-website_membership branch from 7c3ffd4 to a42400f Compare June 29, 2026 07:34
Comment thread website_membership/views/website_membership_templates.xml Outdated
@victoralmau
victoralmau force-pushed the 19.0-mig-website_membership branch from a42400f to cbcdc76 Compare July 21, 2026 07:03
carlos-lopez-tecnativa added a commit to Tecnativa/OpenUpgrade that referenced this pull request Jul 21, 2026
This module was removed from Odoo in odoo/odoo#197228, but it has now been backported to OCA in OCA/vertical-association#226. Therefore, it should be removed from the `merged_modules` variable.

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about updating the style to match the website_crm_partner_assign module instead of keeping the current style in order to align it with Odoo's website style?

Image Image

Comment thread website_membership/security/website_membership.xml Outdated
Comment thread website_membership/__manifest__.py Outdated
@victoralmau
victoralmau force-pushed the 19.0-mig-website_membership branch 2 times, most recently from cbcdc76 to ed31ebc Compare July 23, 2026 08:42
@pilarvargas-tecnativa

Copy link
Copy Markdown
Contributor

What do you think about updating the style to match the website_crm_partner_assign module instead of keeping the current style in order to align it with Odoo's website style?

@carlos-lopez-tecnativa Could you please check it again?

@eduezerouali-tecnativa eduezerouali-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice change

Image

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration website_membership

@pilarvargas-tecnativa please remove [19.0] from the commit message.

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Jul 23, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 23, 2026
11 tasks
@pilarvargas-tecnativa
pilarvargas-tecnativa force-pushed the 19.0-mig-website_membership branch from 8476f6a to bea2bf7 Compare July 23, 2026 13:44
@pilarvargas-tecnativa

Copy link
Copy Markdown
Contributor

/ocabot migration website_membership

@pilarvargas-tecnativa please remove [19.0] from the commit message.

done

</t>
</button>
<div class="dropdown-menu">
<t t-foreach="countries" t-as="country">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to avoid rendering empty countries when the partner does not have a country set. The filter does not work in this case.
Image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

@pilarvargas-tecnativa
pilarvargas-tecnativa force-pushed the 19.0-mig-website_membership branch from bea2bf7 to 267313b Compare July 24, 2026 07:27

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a non-logged-in user, the result is different in the country counter.
This occurs when the membership product is not published on the website.
Please ensure consistency between the records and the counters.

Image Image

@pilarvargas-tecnativa

Copy link
Copy Markdown
Contributor

ping @carlos-lopez-tecnativa

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvements!

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-226-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot

Copy link
Copy Markdown
Contributor

@pedrobaeza The merge process could not be finalized, because command twine upload --disable-progress-bar --non-interactive --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_website_membership-19.0.1.0.0.5-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_website_membership-19.0.1.0.0.5-py3-none-any.whl
�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 429 Too Many Requests from https://upload.pypi.org/legacy/  
         Too Many Requests                                                      

@pedrobaeza

Copy link
Copy Markdown
Member

@sbidoul can you reserve this name on PyPi?

@sbidoul

sbidoul commented Jul 28, 2026

Copy link
Copy Markdown
Member

Name reserved

@pedrobaeza

Copy link
Copy Markdown
Member

Thanks!

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-226-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 57e1d5b into OCA:19.0 Jul 28, 2026
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at b891a4e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
pedrobaeza deleted the 19.0-mig-website_membership branch July 28, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants