[18.0][MIG] web_responsive: Migration to 18.0 by chaule97 · Pull Request #3057 · OCA/web

chaule97 · 2025-01-14T05:24:51Z

The features this module brings compared to native:
- New navigation with the fullscreen app menu
- Quick menu search inside the app menu
- Sticky header & footer in list view
- Sticky statusbar in form view
- Bigger checkboxes in list view
- Followers and send button is displayed on mobile. Avatar is hidden.
- Big inputs on form in edit mode
- Keyboard shortcuts for easier navigation, using `Alt + Shift + [NUM]`
- Autofocus on search menu box when opening the app menu
- When the chatter is on the side part, the document viewer fills that part for side-by-side reading instead of full screen
- When the user chooses to send a public message the color of the composer is different from the one when the message is an internal log.
any changes in v18:
-Control panel buttons use icons to save space. function is removed

because odoo 18 changed template

* Add Tecnativa as author * Remove untestable JS method * Rename to web_responsive

* Bump version * Change all openerp to odoo * Fix qunit suite injection * Remove jQuery require * Change to new selectors: * `oe_leftbar` to `o_sub_menu` * `oe_logo` to `o_sub_menu_logo` * `oe_footer` to `o_sub_menu_footer` * `oe_secondary_menus_container` to `o_sub_menu_content` * Add style to hide oe_footer instead of remove to not break `support_branding` * Add note in ReadMe explaining override of `support_branding` * Set top margin of app drawer title to 0 to fit v10 proportions * Fix notification badge positioning * Add o_web_client class to body to fix overlaps * Scroll control panel with page * Change navbar z-index to not be overlapped by buttons * Raise z-index on header to raise over buttons * Handle layered notifications via z-index * Remove `#` from navigation links HREF to prevent history littering

* Rebalance z-indexes to fix overlay issue while still providing notification support

* Bold titles for apps in the app-drawer * Remove z-index from Control Panel buttons, so it doesn't overlap the menu. * Better responsive menus * Move systray icons/menus out of the menu and up to the top bar. * Increase avatar size and visibility. * Other minor menu behavior fixes. * Changes to fit odoo variables * And a little margin adjust on navbar-right * Top menu always thick * Removed overflow:hidden!important from main.less * Local patch: prevent body overflow auto * Stop using `style=` on `<body>` * Fix jquery drawer in anticipation of: blivesta/drawer#36

On screens with less than 768px content is limited to 2 columns. On mobile field labels have their own line. Fix elements width for XS screens

Make image editing controls always available, instead of depending on resolution or hover.

Small makeup to make it look good in XS screens.

* [IMP] drawer-toggle * [IMP] Hitbox of close drawer-toggle * [IMP] Removed outline on menu item * [IMP] Logo positionings * [FIX] Try me on runbot button * [REM] Reversed outline change

* Change accesskey for `edit` in form view back to `e` to fix OCA#587

Before this patch, there was an incompatibility between this addon and l10n_es_toponyms, caused by the lack of wrapping of the special address field that was being added. Now layout works as expected in that case. In any other case, it seems sensible to wrap inputs so no more weird overflows happen and less chances of needing horizontal scrolling happen.

* Initial commit * Initial commit

* FIX hasclass * FIX views * [FIX] web_responsive: Syntax error in xpath

* Update to iScoll bleeding edge to fix OCA#741

* Add a call to the window resize method during init to fix OCA#773

…sues 808 (OCA#809) Closes OCA#808

…OCA#951)

HviorForgeFlow

Functional review.

Click on an entry that has been found from a search in the menu link is broken. It uses old way action_id=123 but keeps the /odoo/action-321 old (for instance http://localhost:8069/odoo/action-123?action_id=321&menu_id=456). I guess that the href should be build with the new reference.

chaule97 · 2025-01-20T03:04:50Z

Functional review.

Click on an entry that has been found from a search in the menu link is broken. It uses old way action_id=123 but keeps the /odoo/action-321 old (for instance http://localhost:8069/odoo/action-123?action_id=321&menu_id=456). I guess that the href should be build with the new reference.

Thanks, I have fixed it

kobros-tech

there is a test file and you removed it too, here is the content:

License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl). */
odoo.define("web_responsive.test_patch", function (require) {
"use strict";

const utils = require("web_tour.TourStepUtils");

/* Make base odoo JS tests working */
utils.include({
showAppsMenuItem() {
return {
edition: "community",
trigger: ".o_navbar_apps_menu",
auto: true,
position: "bottom",
};
},
});
});`

web_responsive/static/tests/test_patch.js

could you explain, please?

kobros-tech · 2025-01-22T13:34:02Z

web_responsive/tests/test_ir_http.py

+from odoo.tests import HttpCase
+
+
+class TestIrHttp(HttpCase):


Is there a reason to remove this tag:
@tagged("-at_install", "post_install")

because of this error:
File "/opt/odoo/odoo/sql_db.py", line 572, in execute return self._cursor.execute(*args, **kwargs) File "/opt/odoo/odoo/sql_db.py", line 354, in execute res = self._obj.execute(query, params) psycopg2.errors.UndefinedColumn: column res_users.user_year_born does not exist LINE 1: ...apps_menu_theme", "res_users"."is_redirect_home", "res_users... in module web_pivot_computed_measure

So, I think testcase in web_responsive should be runned first

SplashS · 2025-01-23T06:39:16Z

web_responsive/static/tests/test_patch.js

This file was necessary for testing engine in general.
Odoo testing framework in part of browser integration tests (post_install) make clicks.
And it also wants to click on the main menu.
But web_responsive module changes the main menu and the way to click it programmatically.
This file allowed post_install tests to work.

pedrobaeza · 2025-01-28T07:55:23Z

There's already #3037 doing the migration.

chaule97 · 2025-02-04T03:19:03Z

web_responsive/static/tests/test_patch.js

This file was necessary for testing engine in general. Odoo testing framework in part of browser integration tests (post_install) make clicks. And it also wants to click on the main menu. But web_responsive module changes the main menu and the way to click it programmatically. This file allowed post_install tests to work.

I don't think so. in module web_pivot_computed_measure, it has click o_navbar_apps_menu step, but github ci test still passes. I think we don't need it anymore because of this css

chaule97 · 2025-02-05T11:02:20Z

There's already #3037 doing the migration.

Hi @pedrobaeza , compare to #3037:

my PR only fix attributes of web.NavBar.AppsMenu, 3037 replace this web.NavBar.AppsMenu
my PR fix clean code, example: 1, 2, 3, 4
Control panel buttons use icons to save space. function is removed

because odoo 18 changed template

I deleted web_responsive/static/tests/test_patch.js because it is not necessary anymore

pilarvargas-tecnativa · 2025-02-06T06:50:26Z

Hello! I think the correct way to proceed is to make the appropriate corrections in the existing PR and if they are not attended by the author then open a new PR from the existing one. For the time being, the older PR is still being taken care of and has priority over this one. Please, can you provide your revisions?

chaule97 · 2025-02-06T07:54:44Z

Hello! I think the correct way to proceed is to make the appropriate corrections in the existing PR and if they are not attended by the author then open a new PR from the existing one. For the time being, the older PR is still being taken care of and has priority over this one. Please, can you provide your revisions?

It's my task, but I still encourage him to research my updates.

Removed the optimisation of hiding the week number at a certain size for consistency with the responsive design of Odoo enterprise. It is a non-functional optimisation as it hides useful information that hardly takes up any space. It also causes incompatibilities in the design with extensions that do not take into account these specific changes. TT54811

kobros-tech · 2025-03-27T14:25:59Z

@chaule97
@pedrobaeza
@pilarvargas-tecnativa

I like that @chaule97 isolated this module from the error appearing because of other module.
I will compare both, if this one is already includes necessary updates without any issue, I don't mind to merge.

Give me a few to review and come back...

pedrobaeza

This migration is losing 2 features that are required for me:

The non mandatory preview of the main attachment and the preview bar sided with possibility of maximizing the preview.
The previous menu search, because the old one was more flexible typing any part of the menu path. Look here:

If I type an extra p, no menu entry is found, where it should:

kobros-tech · 2025-03-27T18:03:11Z

web_responsive/static/tests/test_patch.js

This file was necessary for testing engine in general. Odoo testing framework in part of browser integration tests (post_install) make clicks. And it also wants to click on the main menu. But web_responsive module changes the main menu and the way to click it programmatically. This file allowed post_install tests to work.

No need to remove the file, I agree with you!
Instead of fixing the cause of issue he escaped by removing the test case, could have better at least delete the model and its related fields as they are only for test cases and no longer needed in the test database.

In fact I preferred a better solution to test already existing models like res.partner
There is a PR of the fix of the test case #3038 I asked @pedrobaeza to talk with people and get it merged or even delete the demo model after fishing the test there, I don't prefer this solution!

Now this module does not need any change in its test cases, I did not change!
For @chaule97 he made entire change, he could have pulled my branch and add only necessary changes

Now I will review the changes, and welcome to have previews there but once I finish with his commit.

Only what I need now is this #3038 to be merged.

kobros-tech · 2025-04-12T13:23:52Z

among all my review, you have good js to format but we are a community!

I write, then you, then someone else. Writing on top of previous is valuable in issue solving.

I hade to inherit with replacement as the thing was taking size even if I hide it. I whish if I can take some you your changes but you didn't help me to choose the most important changes.

There is a syntax to assign classes the modern way, I like it but it still not solving an issue except for nice looking.

chaule97 · 2025-04-12T13:25:58Z

among all my review, you have good js to format but we are a community!

I write, then you, then someone else. Writing on top of previous is valuable in issue solving.

I hade to inherit with replacement as the thing was taking size even if I hide it. I whish if I can take some you your changes but you didn't help me to choose the most important changes.

There is a syntax to assign classes the modern way, I like it but it still not solving an issue except for nice looking.

Sorry, I am so busy. I will review your PR tomorrow

pedrobaeza · 2025-04-21T10:30:13Z

According to comments, closing this one for adopting finally #3037

lasley and others added 30 commits January 10, 2025 15:53

[FIX] web_responsive: Other minor fixes

ffd02a0

* Add Tecnativa as author * Remove untestable JS method * Rename to web_responsive

[FIX] web_responsive: Change z-indexes

a0df61c

* Rebalance z-indexes to fix overlay issue while still providing notification support

Form view improvements to fit smaller screens

99d7e68

On screens with less than 768px content is limited to 2 columns. On mobile field labels have their own line. Fix elements width for XS screens

Form image editing controls always present

05b1484

Make image editing controls always available, instead of depending on resolution or hover.

Fix problem with overflowing chatter widget.

a09f58f

[FIX][web_responsive] Form padding, titles and buttons OK in XS

25dfd3a

Small makeup to make it look good in XS screens.

[10.0][IMP][web_responsive] (OCA#569)

dd1a8e4

* [IMP] drawer-toggle * [IMP] Hitbox of close drawer-toggle * [IMP] Removed outline on menu item * [IMP] Logo positionings * [FIX] Try me on runbot button * [REM] Reversed outline change

Update README to fix wikipedia link

4158239

[FIX] web_responsive: Change edit accesskey

924e39c

* Change accesskey for `edit` in form view back to `e` to fix OCA#587

[FIX] web_responsive: Execution permission

e22b31e

[10.0][IMP][web_responsive] Make search bar sticky (OCA#633)

09fc49e

* Initial commit * Initial commit

[FIX][web_responsive] Long-named multicompanies nice in XS (OCA#688)

c77979e

[10.0][IMP] web_responsive: Load default kanban view for small screen

e44c4cc

UPDT version

0c2d34f

FIX travis (OCA#747)

1fb7cfd

* FIX hasclass * FIX views * [FIX] web_responsive: Syntax error in xpath

[FIX] web_responsive: Chrome Slow Scrolling

2121d1e

* Update to iScoll bleeding edge to fix OCA#741

[FIX] web_responsive: Correct runbot link

bb656b5

[MIG] web_responsive test to 11.0

04858a8

[FIX] web_responsive: Menu Height on Init

08bc130

* Add a call to the window resize method during init to fix OCA#773

[FIX] web_responsive: Hide header when print directly from browser is…

05c148b

…sues 808 (OCA#809) Closes OCA#808

[IMP] web_responsive: Possibility of putting the chatter in the right (…

63dd6a2

…OCA#951)

[UPD] README.rst

299422b

[FIX] Chatter Position

fd70fdc

[FIX] Read/Write permissions

de23e67

[CLEAN] Comments

ccc58fc

[IMP] Code

c22dae1

[IMP] Adding res.users chatter_position read/write test

bf58cf4

chaule97 force-pushed the 18.0-mig-web_responsive branch 4 times, most recently from b390c4c to a6c6a73 Compare January 15, 2025 02:49

HviorForgeFlow suggested changes Jan 17, 2025

View reviewed changes

chaule97 force-pushed the 18.0-mig-web_responsive branch from a6c6a73 to 1906d56 Compare January 20, 2025 03:02

chaule97 requested a review from HviorForgeFlow January 20, 2025 03:07

chaule97 mentioned this pull request Jan 22, 2025

[18.0][MIG] web_responsive: Migration to 18.0 #3037

Merged

kobros-tech suggested changes Jan 22, 2025

View reviewed changes

chaule97 marked this pull request as ready for review February 4, 2025 03:08

pilarvargas-tecnativa and others added 3 commits February 6, 2025 14:58

[IMP] web_responsive: pre-commit auto fixes

17da773

[MIG] web_responsive: Migration to 18.0

53a4d53

chaule97 force-pushed the 18.0-mig-web_responsive branch from 1906d56 to 53a4d53 Compare February 6, 2025 07:58

pedrobaeza requested changes Mar 27, 2025

View reviewed changes

pedrobaeza mentioned this pull request Mar 27, 2025

[18.0][FIX] web_pivot_computed_measure: fix tests #3038

Merged

pedrobaeza closed this Apr 21, 2025

chaule97 deleted the 18.0-mig-web_responsive branch November 24, 2025 09:14

Uh oh!

Conversation

chaule97 commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HviorForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

chaule97 commented Jan 20, 2025

Uh oh!

kobros-tech left a comment

Choose a reason for hiding this comment

Uh oh!

kobros-tech Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

chaule97 Feb 5, 2025

Choose a reason for hiding this comment

Uh oh!

SplashS commented Jan 23, 2025

Uh oh!

pedrobaeza commented Jan 28, 2025

Uh oh!

chaule97 commented Feb 4, 2025

Uh oh!

chaule97 commented Feb 5, 2025

Uh oh!

pilarvargas-tecnativa commented Feb 6, 2025

Uh oh!

chaule97 commented Feb 6, 2025

Uh oh!

kobros-tech commented Mar 27, 2025

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

kobros-tech commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kobros-tech commented Apr 12, 2025

Uh oh!

chaule97 commented Apr 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pedrobaeza commented Apr 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

chaule97 commented Jan 14, 2025 •

edited

Loading

kobros-tech commented Mar 27, 2025 •

edited

Loading

chaule97 commented Apr 12, 2025 •

edited

Loading