Skip to content

[18.0][MIG] web_widget_pattern: Migration to 18.0#3059

Closed
sensiblecs wants to merge 5 commits intoOCA:18.0from
Sensible-Consulting-Services:18.0-mig-web_widget_pattern
Closed

[18.0][MIG] web_widget_pattern: Migration to 18.0#3059
sensiblecs wants to merge 5 commits intoOCA:18.0from
Sensible-Consulting-Services:18.0-mig-web_widget_pattern

Conversation

@sensiblecs
Copy link
Copy Markdown

No description provided.

@sensiblecs sensiblecs mentioned this pull request Feb 25, 2025
48 tasks
@hbrunn hbrunn closed this Dec 2, 2025
@hbrunn hbrunn reopened this Dec 2, 2025
Copy link
Copy Markdown
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further testing reveals several problems:

  • the pattern doesn't work when setting the pattern parameter on a field in python code
    You need to patch Field.parseFieldNode for this:
    +import {Field} from  "@web/views/fields/field";
    ...
    +patch(Field, {
    +    parseFieldNode(node, models, modelName, viewType, jsClass) {
    +        const fieldInfo = super.parseFieldNode(...arguments);
    +        fieldInfo.pattern = models[modelName].fields[fieldInfo.name].pattern;
    +        return fieldInfo;
    +    }
    +});
    and change extractProps accordingly
  • function base#fields_get should check for attributes being falsy, not None
  • function base#_get_view_field_attributes doesn't exist any more, so this override should be removed
  • the autocomplete component now inherits from Char, so this override should be removed too
  • please fix the tests

@hbrunn
Copy link
Copy Markdown
Member

hbrunn commented Apr 14, 2026

superseded by #3511

@hbrunn hbrunn closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants