[18.0][MIG] web_widget_pattern: Migration to 18.0#3059
Closed
sensiblecs wants to merge 5 commits intoOCA:18.0from
Closed
[18.0][MIG] web_widget_pattern: Migration to 18.0#3059sensiblecs wants to merge 5 commits intoOCA:18.0from
sensiblecs wants to merge 5 commits intoOCA:18.0from
Conversation
Currently translated at 100.0% (1 of 1 strings) Translation: web-16.0/web-16.0-web_widget_pattern Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_pattern/it/
[IMP] web_widget_pattern: pre-commit auto fixes [REM] unused file
hbrunn
approved these changes
Jul 18, 2025
hbrunn
requested changes
Dec 2, 2025
Member
There was a problem hiding this comment.
Further testing reveals several problems:
- the pattern doesn't work when setting the pattern parameter on a field in python code
You need to patch Field.parseFieldNode for this:and change+import {Field} from "@web/views/fields/field"; ... +patch(Field, { + parseFieldNode(node, models, modelName, viewType, jsClass) { + const fieldInfo = super.parseFieldNode(...arguments); + fieldInfo.pattern = models[modelName].fields[fieldInfo.name].pattern; + return fieldInfo; + } +});
extractPropsaccordingly - function
base#fields_getshould check forattributesbeing falsy, notNone - function
base#_get_view_field_attributesdoesn't exist any more, so this override should be removed - the autocomplete component now inherits from Char, so this override should be removed too
- please fix the tests
Member
|
superseded by #3511 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.