Skip to content

Conversation

@SirPyTech
Copy link
Contributor

@SirPyTech SirPyTech commented Feb 2, 2026

Otherwise function calls are not evaluated in the created attachment.

Right now it is not needed because the created attachment does not use any functions, but if any were added, that would not be evaluated.

For instance, try editing the created CSS by adding a call to the desaturate function like:

.app-menu-container {
    background: url('/web_responsive/static/src/img/home-menu-bg-overlay.svg'),
        linear-gradient(
            to bottom,
            %(color_navbar_bg)s,
            desaturate(lighten(%(color_navbar_bg)s, 20%%), 15)
        );
}

that would be sent to the client as-is resulting in something like:

.app-menu-container {
    background: url('/web_responsive/static/src/img/home-menu-bg-overlay.svg'),
        linear-gradient(
            to bottom,
            #123456,
            desaturate(lighten(#123456, 20%), 15)
        );
}

that is not acceptable CSS, and thus is not evaluated.

Other SCSS assets are automatically compiled in their bundle, but this one skips that procedure because of the overrides for the web_company_color.company_color_assets bundle.

@SirPyTech SirPyTech marked this pull request as draft February 2, 2026 11:37
Otherwise function calls are not evaluated in the created attachment
@SirPyTech SirPyTech force-pushed the 18.0-imp-web_compny_color-compile_scss branch from 1705b71 to 177d482 Compare February 2, 2026 12:02
@SirPyTech SirPyTech marked this pull request as ready for review February 2, 2026 12:09
Copy link

@quirino95 quirino95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review LGTM

@pedrobaeza pedrobaeza added this to the 18.0 milestone Feb 6, 2026
@pedrobaeza pedrobaeza changed the title [IMP] web_company_color: Compile SCSS [18.0][IMP] web_company_color: Compile SCSS Feb 6, 2026
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-3427-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5a7bd88 into OCA:18.0 Feb 6, 2026
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b2d8e92. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants