[FIX] web_widget_numeric_step: Added migration script for migration to 16.0.

[baguenth]

In version before odoo 16.0 there have been demo data in web_widget_numeric_step. This demo data contained a view for res users. Before odoo 16.0, the field credit_limit was defined in res.users model. In odoo 16.0 it was moved to res.partner.

<?xml version="1.0" encoding="UTF-8" ?>
<!-- Copyright 2020 Tecnativa - Alexandre Díaz
     License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -->
<odoo>
    <record id="view_users_form" model="ir.ui.view">
        <field name="model">res.users</field>
        <field name="inherit_id" ref="base.view_users_form" />
        <field name="arch" type="xml">
            <xpath expr="//div[hasclass('oe_title')]" position="after">
                <group>
                    <field
                        name="credit_limit"
                        widget="numeric_step"
                        options="{'step': 3, 'min': -10, 'max': 130}"
                    />
                </group>
            </xpath>
        </field>
    </record>
</odoo>

Demo data was removed when the module was migrated, but the view was never actively dropped in a migration script. This causes issues when migrating databases, which have been initialized with demo data.

[OCA-git-bot]

Hi @yajo, @rafaelbn,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

Thanks for the PR. Demo data are not populated on regular instances, so this doesn't apply. Any reason for it?

[baguenth]

Totally agree. Demo data should not be in regular environments. Nevertheless we had the issue in an older customer database and therefore the migration failed. We fixed it internally with the migration script.

I just wanted to provide this fix to the community, in case someone else runs into the same issue. Also fine for me to close the topic, since having demo data in production is not a regular case.

[pedrobaeza]

Thanks for the explanations and your understanding. As this is a corner case, if you don't mind, I'm closing it.