Open
Conversation
mathben
force-pushed
the
18.0_imp_web_menu_reorder
branch
from
b87563c to
42f8936
Compare
legalsylvain
requested changes
Apr 2, 2026
Contributor
legalsylvain
left a comment
legalsylvain
left a comment
There was a problem hiding this comment.
thanks for your contribution.
Comment on lines
+53
to
+67
| def get_values(self): | ||
| res = super().get_values() | ||
| res["menu_order_labels"] = ( | ||
| self.env["ir.config_parameter"] | ||
| .sudo() | ||
| .get_param("menu_reorder_settings.menu_order_labels", default="") | ||
| ) | ||
| return res | ||
|
|
||
| def set_values(self): | ||
| super().set_values() | ||
| self.env["ir.config_parameter"].sudo().set_param( | ||
| "menu_reorder_settings.menu_order_labels", | ||
| self.menu_order_labels or "", | ||
| ) |
Contributor
There was a problem hiding this comment.
you could remove this section, and just use the nativ configuration parameter ? don't you think ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder top-level menus alphabetically or by custom label list or by default (sequence)