Conversation
anthonysena
requested changes
Oct 31, 2025
anthonysena
left a comment
anthonysena
left a comment
Contributor
There was a problem hiding this comment.
Left some comments to wrap up the release. One other thing to change: in .github/workflows/R_CMD_check_HADES.yaml update the Test Coverage to use this approach for calling the covr package: https://github.com/OHDSI/CohortGenerator/blob/main/.github/workflows/R_CMD_check_Hades.yaml#L158-L164
Fix column case mismatch between export queries and R code
Update achilles_analysis_details.csv
Update achilles_analysis_details.csv
Update achilles_analysis_details.csv
anthonysena
requested changes
Dec 3, 2025
Contributor
There was a problem hiding this comment.
Looks like the package manual needs to be regenerated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.