display concept name if available

R/conceptSearchModule.R

@@ -53,7 +53,13 @@ hecateConceptLabel <- function(conceptId) {
     return("(invalid concept id)")
   }
 
-  "(valid concept id)"
+  concept_name <- concept$conceptName %||% NA_character_
+  concept_name <- as.character(concept_name)
+  if (length(concept_name) != 1 || is.na(concept_name) || !nzchar(concept_name)) {
+    return("(invalid concept id)")
+  }
+
+  return(concept_name)
 }
 
 #' @describeIn conceptSearchModule UI for the concept search: a single button that opens the search modal.

tests/testthat/helper-internals.R

@@ -8,3 +8,4 @@ new_cdm_table <- function(type) {
 
 cdm_table_server <- getFromNamespace("cdmTableServer", "PatientGenerator")
 normalize_bar_end_update <- getFromNamespace("normalizeBarEndUpdate", "PatientGenerator")
+hecate_concept_label <- getFromNamespace("hecateConceptLabel", "PatientGenerator")

tests/testthat/test-conceptSearchModule.R

@@ -0,0 +1,48 @@
+test_that("hecateConceptLabel returns concept names for valid concept ids", {
+  testthat::local_mocked_bindings(
+    hecateSearch = function(query, limit = 10) {
+      data.frame(
+        conceptId = c(3018251L, 201826L),
+        conceptName = c("Hemoglobin A1c measurement", "Type 2 diabetes mellitus"),
+        invalidReason = c(NA_character_, NA_character_)
+      )
+    },
+    .package = "PatientGenerator"
+  )
+
+  expect_equal(
+    hecate_concept_label("3018251"),
+    "Hemoglobin A1c measurement"
+  )
+})
+
+test_that("hecateConceptLabel returns invalid concept id for invalid or missing concepts", {
+  testthat::local_mocked_bindings(
+    hecateSearch = function(query, limit = 10) {
+      data.frame(
+        conceptId = 3018251L,
+        conceptName = "Hemoglobin A1c measurement",
+        invalidReason = NA_character_
+      )
+    },
+    .package = "PatientGenerator"
+  )
+
+  expect_equal(hecate_concept_label("abc"), "(invalid concept id)")
+  expect_equal(hecate_concept_label("9999999"), "(not found)")
+})
+
+test_that("hecateConceptLabel returns invalid concept id for invalid vocabulary concepts", {
+  testthat::local_mocked_bindings(
+    hecateSearch = function(query, limit = 10) {
+      data.frame(
+        conceptId = 123L,
+        conceptName = "Old concept",
+        invalidReason = "D"
+      )
+    },
+    .package = "PatientGenerator"
+  )
+
+  expect_equal(hecate_concept_label("123"), "(invalid concept id)")
+})