tests: Add 15 L2TPv3 tests and 1 L2TPv2 test#2748
Open
poodle-amazon wants to merge 1 commit intoOISF:masterfrom
Open
tests: Add 15 L2TPv3 tests and 1 L2TPv2 test#2748poodle-amazon wants to merge 1 commit intoOISF:masterfrom
poodle-amazon wants to merge 1 commit intoOISF:masterfrom
Conversation
5 tasks
poodle-amazon
force-pushed
the
master
branch
2 times, most recently
from
c7a496b to
ef1a757
Compare
poodle-amazon
changed the title
5 tasks
poodle-amazon
force-pushed
the
master
branch
2 times, most recently
from
6d67dc8 to
fb74f9f
Compare
poodle-amazon
changed the title
Issue: 7986 * v2 test is from a public PCAP on Wireshark * v3 tests 01 to 12 are Linux's L2TPv3 implementation * v3 tests 13/14 are for a UDP tunnel between a Juniper MIST Edge and a MIST AP * v3 test 15 is an invalid child tunnel (IP version is wrong)
poodle-amazon
force-pushed
the
master
branch
from
fb74f9f to
eb38d5c
Compare
Member
|
Can you also add decoder event tests/checks? That would have caught that they weren't registered correctly and not logged in stats. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: 7986