Open
Conversation
Add tests for the geoip-enrichment output feature. - geoip-enrichment: Tests that geoip_dst fields are added to alert and flow events when geoip-enrichment is enabled - geoip-enrichment-disabled: Tests that NO events have geoip fields when geoip-enrichment is disabled Ticket: 6999
This was referenced Jan 3, 2026
jufajardini
requested changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
Thanks for adding tests :)
We must also require a min-version: 9.0 check, to ensure they're only tested against main.
In addition to the inline comments, could we adjust the test so that it would show all of the GeoIP enrichment that is being added? When I ran it locally, I only got:
"geoip_dst": {
"ip": "82.165.177.154",
"geo": {
"country_iso_code": "DE"
}
},| count: 1 | ||
| match: | ||
| event_type: flow | ||
| has-key: geoip_dst |
Contributor
There was a problem hiding this comment.
nit: since we have the check below, this has-key isn't needed
Contributor
There was a problem hiding this comment.
(same for the previous check)
| count: 0 | ||
| match: | ||
| event_type: alert | ||
| has-key: geoip_dst |
Contributor
There was a problem hiding this comment.
You can use not-has-key, instead.
Author
|
Thank you for the quick feedback @jufajardini! When I submit my changes, do I open a new PR or can I push them to this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for the geoip-enrichment output feature
geoip-enrichment: Tests that geoip fields are added to alert and flow events when
geoip-enrichment is enabled
geoip-enrichment-disabled: Tests that NO events have geoip fields when geoip-enrichment is disabled
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6999