detect/proto: check ipproto enabled setting first#14713
Closed
detect/proto: check ipproto enabled setting first#14713
Conversation
So far, suricata.yaml was probed by default for `app-layer.protocols.PROTOCOL.enabled`. If this was not found, then, an attempt was made to look for `app-layer.protocols.PROTOCOL.IPPROTO.enabled`. This is not ideal behavior and restricts user to explicitly disable a carrier proto specific protocol. By default, check for carrier proto specific setting. If it is not found, then fall back to the generic setting. Bug 8205
inashivb
commented
Jan 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14713 +/- ##
==========================================
+ Coverage 82.13% 82.14% +0.01%
==========================================
Files 1011 1011
Lines 263295 263295
==========================================
+ Hits 216258 216290 +32
+ Misses 47037 47005 -32
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR: #14699
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8205
Changes since v2:
SV_BRANCH=OISF/suricata-verify#2893
Note: This should NOT affect any existing setups and configs. If you see that happening, it should be reported as a bug.