Skip to content

Smb rust keywords 8267 v1.1#14756

Open
catenacyber wants to merge 6 commits intoOISF:mainfrom
catenacyber:smb-rust-keywords-8267-v1.1
Open

Smb rust keywords 8267 v1.1#14756
catenacyber wants to merge 6 commits intoOISF:mainfrom
catenacyber:smb-rust-keywords-8267-v1.1

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8267

Describe changes:

  • smb: move keywords to rust
  • detect/sip: remove obsolete keyword ids
  • bindgen SCDetectGetLastSMFromLists

I wonder if instead of bindgening variadic SCDetectGetLastSMFromLists, I should have made a helper which takes only one arg...

#14755 with all commits that build even if we change some C code to remove it one commit later

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 98.78543% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.15%. Comparing base (69eb567) to head (928cf05).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14756      +/-   ##
==========================================
- Coverage   82.15%   82.15%   -0.01%     
==========================================
  Files        1003     1000       -3     
  Lines      263643   263615      -28     
==========================================
- Hits       216586   216562      -24     
+ Misses      47057    47053       -4     
Flag Coverage Δ
fuzzcorpus 60.19% <98.68%> (+<0.01%) ⬆️
livemode 18.72% <38.42%> (+0.01%) ⬆️
netns 18.53% <38.59%> (+<0.01%) ⬆️
pcap 44.61% <50.21%> (+<0.01%) ⬆️
suricata-verify 65.46% <91.22%> (+<0.01%) ⬆️
unittests 59.24% <57.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 29450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants