Open
Conversation
as they are now dynamically generated
Ticket: 8267
to use it from rust keywords
Ticket: 8267
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14756 +/- ##
==========================================
- Coverage 82.15% 82.15% -0.01%
==========================================
Files 1003 1000 -3
Lines 263643 263615 -28
==========================================
- Hits 216586 216562 -24
+ Misses 47057 47053 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 29450 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8267
Describe changes:
I wonder if instead of bindgening variadic SCDetectGetLastSMFromLists, I should have made a helper which takes only one arg...
#14755 with all commits that build even if we change some C code to remove it one commit later