Misc fixes/v4 - #16136
Open
victorjulien wants to merge 3 commits into
Open
Conversation
SCACTileSearchLarge uses 32-bit next-state cells holding a 24-bit state index. When there are more than 65536 states, CheckMatch was called with (uint16_t)state, silently discarding the bits beyond 16. Address this by widening CheckMatch's state parameter. Ticket: OISF#8841.
Lookup code used a different mask than the construct code. Ticket: OISF#8820.
nfs4_res_secinfo_no_name() used a local var "i2" to walk through the security-flavor array entries, but returned the pre-walk var "i" in the Ok at the end. Every byte of the flavor array was therefore left unconsumed in the input stream and re-interpreted by count next iteration as a subsequent compound operation. Addressed by returning i2 instead of i so all flavor bytes are consumed. Ticket: OISF#8860.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16136 +/- ##
==========================================
- Coverage 83.05% 83.04% -0.02%
==========================================
Files 1004 1004
Lines 277407 277407
==========================================
- Hits 230410 230365 -45
- Misses 46997 47042 +45
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
marked this pull request as ready for review
August 28, 2026 10:17
|
Information: QA ran without warnings. Pipeline = 33425 |
Member
|
I brought the test over for 8860: OISF/suricata-verify#3332 |
jasonish
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redmine.openinfosecfoundation.org/issues/8860
https://redmine.openinfosecfoundation.org/issues/8841
https://redmine.openinfosecfoundation.org/issues/8820
SV_BRANCH=OISF/suricata-verify#3332