Skip to content

[Server] Allow Subject Name Change of Application Certificate in GDS Push scenario#2833

Merged
mrsuciu merged 6 commits intoOPCFoundation:masterfrom
romanett:ChangeSubjectName
Jan 21, 2025
Merged

[Server] Allow Subject Name Change of Application Certificate in GDS Push scenario#2833
mrsuciu merged 6 commits intoOPCFoundation:masterfrom
romanett:ChangeSubjectName

Conversation

@romanett
Copy link
Contributor

@romanett romanett commented Nov 3, 2024

Proposed changes

Extend CertificateIdentifier to allow Certificate to be found by applicationUri in addition to the subject name.
This allows an Administator to perform a certificate update and changing the subject name specified in the application certificate during the process

Related Issues

  • Fixes #

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

@codecov
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (62b4f05) to head (0f9209d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff       @@
##   master   #2833   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mregen mregen added this to the 1.5.375 ECC official release milestone Nov 26, 2024
@romanett romanett self-assigned this Nov 27, 2024
@romanett romanett marked this pull request as ready for review November 29, 2024 13:41
@romanett
Copy link
Contributor Author

Confirmed working with #2861 merged

@romanett romanett requested review from mregen and mrsuciu November 29, 2024 13:41
@romanett romanett removed the request for review from mregen January 13, 2025 05:49
@mrsuciu mrsuciu merged commit 4a44238 into OPCFoundation:master Jan 21, 2025
75 checks passed
@romanett romanett deleted the ChangeSubjectName branch January 21, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants