Skip to content

Add ECDSA support for importing private key from PEM#2941

Merged
mrsuciu merged 3 commits intoOPCFoundation:masterfrom
mrsuciu:master-ECDSA-PEM
Jan 17, 2025
Merged

Add ECDSA support for importing private key from PEM#2941
mrsuciu merged 3 commits intoOPCFoundation:masterfrom
mrsuciu:master-ECDSA-PEM

Conversation

@mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Jan 16, 2025

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

  • Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

{ "nistP256", "1.2.840.10045.3.1.7"},
{ "nistP384", "1.3.132.0.34" },
{ "brainpoolP256r1", "1.3.36.3.3.2.8.1.1.7"},
{ "brainpoolP384r1", "1.3.36.3.3.2.8.1.1.11"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Edwards curve need to be added here?

@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (760bfd9) to head (e1dba27).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #2941       +/-   ##
==========================================
- Coverage   55.44%       0   -55.45%     
==========================================
  Files         352       0      -352     
  Lines       67640       0    -67640     
  Branches    13861       0    -13861     
==========================================
- Hits        37504       0    -37504     
+ Misses      26028       0    -26028     
+ Partials     4108       0     -4108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanett
Copy link
Contributor

@mrsuciu can you upate the method CertificateFactory.CreateCertificateWithPEMPrivateKey to support both RSA and ECC.

With this method adatapter & #2817merged ECC is ready and passes all my ECC GDS Tests (.net9).

I can approve once tests are fixed.

@mrsuciu mrsuciu merged commit 62b4f05 into OPCFoundation:master Jan 17, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants