Add ECDSA support for importing private key from PEM#2941
Merged
mrsuciu merged 3 commits intoOPCFoundation:masterfrom Jan 17, 2025
Merged
Add ECDSA support for importing private key from PEM#2941mrsuciu merged 3 commits intoOPCFoundation:masterfrom
mrsuciu merged 3 commits intoOPCFoundation:masterfrom
Conversation
mregen
reviewed
Jan 16, 2025
Libraries/Opc.Ua.Security.Certificates/Org.BouncyCastle/PEMReader.cs
Outdated
Show resolved
Hide resolved
mregen
approved these changes
Jan 16, 2025
romanett
reviewed
Jan 16, 2025
| { "nistP256", "1.2.840.10045.3.1.7"}, | ||
| { "nistP384", "1.3.132.0.34" }, | ||
| { "brainpoolP256r1", "1.3.36.3.3.2.8.1.1.7"}, | ||
| { "brainpoolP384r1", "1.3.36.3.3.2.8.1.1.11"} |
Contributor
There was a problem hiding this comment.
Does Edwards curve need to be added here?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2941 +/- ##
==========================================
- Coverage 55.44% 0 -55.45%
==========================================
Files 352 0 -352
Lines 67640 0 -67640
Branches 13861 0 -13861
==========================================
- Hits 37504 0 -37504
+ Misses 26028 0 -26028
+ Partials 4108 0 -4108 ☔ View full report in Codecov by Sentry. |
romanett
reviewed
Jan 16, 2025
Libraries/Opc.Ua.Security.Certificates/Org.BouncyCastle/PEMReader.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@mrsuciu can you upate the method CertificateFactory.CreateCertificateWithPEMPrivateKey to support both RSA and ECC. With this method adatapter & #2817merged ECC is ready and passes all my ECC GDS Tests (.net9). I can approve once tests are fixed. |
romanett
reviewed
Jan 16, 2025
Libraries/Opc.Ua.Security.Certificates/Org.BouncyCastle/PEMReader.cs
Outdated
Show resolved
Hide resolved
…eros to match keySize
romanett
approved these changes
Jan 17, 2025
…icate depending on certificate type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...