Skip to content

Refactor ApplicationConfiguration serialization for deprecated/modern settings and add tests for configuration behavior#3415

Merged
mrsuciu merged 6 commits intoOPCFoundation:masterfrom
mrsuciu:IsDeprecatedConfiguration
Dec 17, 2025
Merged

Refactor ApplicationConfiguration serialization for deprecated/modern settings and add tests for configuration behavior#3415
mrsuciu merged 6 commits intoOPCFoundation:masterfrom
mrsuciu:IsDeprecatedConfiguration

Conversation

@mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Dec 12, 2025

Refactor ApplicationConfiguration serialization for deprecated/modern settings and add tests for configuration behavior

Proposed changes

Added serialization guards and tests to ensure "legacy" configs stay marked deprecated and modern configurations stay "non-deprecated".

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@mrsuciu mrsuciu requested a review from romanett December 12, 2025 16:57
@mrsuciu mrsuciu assigned marcschier and unassigned marcschier Dec 12, 2025
@mrsuciu mrsuciu requested a review from marcschier December 12, 2025 16:58
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.99%. Comparing base (d25caff) to head (f2836ca).
⚠️ Report is 58 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3415      +/-   ##
==========================================
+ Coverage   51.86%   59.99%   +8.12%     
==========================================
  Files         370      377       +7     
  Lines       78618    78754     +136     
  Branches    13650    13716      +66     
==========================================
+ Hits        40779    47250    +6471     
+ Misses      33705    27127    -6578     
- Partials     4134     4377     +243     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrsuciu mrsuciu merged commit d7da70b into OPCFoundation:master Dec 17, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serializing and deserializing a "legacy" or "modern" configuration does not preserve SecurityConfiguration.IsDeprecatedConfiguration flag

3 participants