Fix ObjectDisposedException in SubscriptionManager background tasks on shutdown #3456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
During server shutdown, background tasks (
PublishSubscriptionsAsyncandConditionRefreshWorkerAsync) can race withDispose(), attempting to access disposedSemaphoreSlimandManualResetEventobjects. This causesObjectDisposedExceptionerrors in logs despite being a benign shutdown sequence.Solution: Catch
ObjectDisposedExceptionin both background tasks and log as normal shutdown instead of error.Types of changes
Checklist
Further comments
No tests added - the race condition is timing-dependent and difficult to reproduce reliably. The fix is defensive: it handles an expected shutdown scenario gracefully rather than modifying coordination logic.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.