Skip to content

Conversation

@marcschier
Copy link
Collaborator

@marcschier marcschier commented Jan 13, 2026

Proposed changes

Allow creating variant from uint and uint[] with status code type info.

Related Issues

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@marcschier
Copy link
Collaborator Author

@copilot add tests for the changes in this PR. Specifically test casting the Variant "Value" object to StatusCode when the Variant was created with a uint and TypeInfo.Scalar.StatusCode or TypeInfo.Array.StatusCode. Ensure the tests are passing or otherwise update the change.

Copy link
Contributor

Copilot AI commented Jan 13, 2026

@marcschier I've opened a new pull request, #3473, to work on those changes. Once the pull request is ready, I'll request review from you.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ marcschier
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@marcschier marcschier marked this pull request as ready for review January 13, 2026 14:32
@marcschier marcschier merged commit 288f02f into master Jan 14, 2026
129 of 130 checks passed
@marcschier marcschier deleted the scvariant branch January 14, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StatusCode cast from boxed value (object) does not work, but is expected to work in the encoders

4 participants