Support radial grids as cylindrical cells#12936
Merged
Conversation
Moves grid view update logic to RigReservoirGridTools for reuse and consistency. Adds cylindrical coordinate import and radial grid refinement functionality. This automatically creates a LGR for radial grids with low angular resolution, improving simulation accuracy.
Enhances the processing of radial grids by adding logic to create Local Grid Refinements (LGRs) when cylindrical coordinate conversion is enabled. This involves checking for valid radial grid data, handling cases with invalid headers, and creating angular grid refinements based on user preferences. Also ensures active cell indexing for multi-grid cases and updates views after grid modifications.
kriben
reviewed
Sep 24, 2025
Collaborator
kriben
left a comment
kriben
left a comment
There was a problem hiding this comment.
Some minor suggestions, but overall OK!
Moves radial grid import logic into a separate function for improved code organization and readability. This change encapsulates the radial grid import and refinement process, including handling of cylindrical coordinates and LGR creation, into a dedicated `checkAndImportRadialGrid` function. The original logic within `importGridAndResultMetaData` is replaced with a call to this new function, simplifying the import process.
kriben
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12875