Use cafPdmUiButton instead of bool in PdmField#13670
Merged
Conversation
Refactors PDM push buttons from boolean fields to use the `addNewButton` API with direct lambda callbacks. This change enforces a new coding guideline to extract complex or multi-line lambdas to dedicated `on*Clicked()` methods, improving code readability and maintainability. - Replaces `PdmField` button fields with `PdmUiOrdering::addNewButton` calls. - Extracts multi-line/control-flow lambdas into named methods in `RimFlowCharacteristicsPlot`, `RimGeoMechCase`, and `RimStatisticsContourMap`. - Removes obsolete `defineEditorAttribute` overrides and `fieldChangedByUi` logic for these buttons. - Updates `RimWellPathFracture` to utilize base class-provided button creation. - Adds new lambda line-count guideline to the coding style documentation. - Includes minor build fixes, such as adding `cafPdmUiButton.h` and correcting tooltip API usage.
magnesj
force-pushed
the
pdm-pushbutton-to-dynamic-button
branch
from
3df22f2 to
a6d5c76
Compare
kriben
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in RimFlowCharacteristicsPlot, RimGeoMechCase, RimStatisticsContourMap
RimGeoMechCase, add missing cafPdmUiButton.h include, fix tooltip API
usage in RimStatisticsContourMap