[LGR] Add test for CpGrid::getParentIntersectionFromLgrBoundary#1023
Open
aritorto wants to merge 2 commits intoOPM:masterfrom
Open
[LGR] Add test for CpGrid::getParentIntersectionFromLgrBoundary#1023aritorto wants to merge 2 commits intoOPM:masterfrom
aritorto wants to merge 2 commits intoOPM:masterfrom
Conversation
aritorto
added
the
manual:irrelevant
Member
Author
|
jenkins build this serial please |
aritorto
force-pushed
the
interInInside
branch
2 times, most recently
from
06ffc16 to
71a27e8
Compare
Member
Author
|
jenkins build this serial please |
Member
Author
|
jenkins build this serial please |
Member
Author
|
jenkins build this serial please |
blattms
reviewed
Apr 17, 2026
| for (const auto& intersection : Dune::intersections(grid.leafGridView(), element)) { | ||
| if (intersection.neighbor() && (intersection.inside().level() != intersection.outside().level())) { | ||
|
|
||
| const auto parentIntersection = grid.getParentIntersectionFromLgrBoundaryFace(intersection); |
Member
There was a problem hiding this comment.
Please do not copy non-pods but use const references. This class does have a few members.
|
|
||
| const auto parentIntersection = grid.getParentIntersectionFromLgrBoundaryFace(intersection); | ||
|
|
||
| const auto parentInterToPoint = grid.currentData().front()->faceToPoint(parentIntersection.id()); |
Member
There was a problem hiding this comment.
Same here. This is an array or vector.
| // - coarse inside (level 0): indexInInside() is already the level-0 face index. | ||
| // - refined inside: fine cells inherit face directions from their parent, so | ||
| // indexInInside() equals the parent's face index. | ||
| const auto insideOrigin = intersection.inside().getOrigin(); |
Member
There was a problem hiding this comment.
This should probably be a reference
Member
Author
|
jenkins build this serial please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a test for an issue reported and fixed in #1022.
This PR should be merged after that one.