Make Zoltan's Hyperedge Size Threshold Runtime Controllable#6036
Merged
bska merged 2 commits intoOPM:masterfrom Mar 11, 2025
Merged
Make Zoltan's Hyperedge Size Threshold Runtime Controllable#6036bska merged 2 commits intoOPM:masterfrom
bska merged 2 commits intoOPM:masterfrom
Conversation
Member
Author
|
As a secondary benefit, this PR will obviate the |
Member
Author
|
jenkins build this please |
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
from
48457fe to
93ead52
Compare
Member
Author
|
jenkins build this please |
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
2 times, most recently
from
9908c4c to
8915efc
Compare
Member
Author
|
jenkins build this please |
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
from
8915efc to
a34d2ef
Compare
Member
Author
|
jenkins build this please |
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
from
a34d2ef to
fd151f0
Compare
Member
Author
|
jenkins build this please |
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
from
fd151f0 to
c9911fa
Compare
Member
Author
|
jenkins build this please |
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
8 times, most recently
from
b786fd3 to
b5f2b52
Compare
Member
Author
|
jenkins build this please |
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
from
b5f2b52 to
6464449
Compare
Member
Author
|
jenkins build this please |
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
2 times, most recently
from
14ae400 to
1f034f7
Compare
Member
Author
|
jenkins build this please |
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
from
1f034f7 to
3258ef9
Compare
Member
Author
|
jenkins build this please |
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
from
3258ef9 to
c847570
Compare
Slight rewording and splitting long lines for the most part.
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
from
c847570 to
8675685
Compare
Member
Author
|
jenkins build this please |
akva2
approved these changes
Mar 11, 2025
| this->zoltanPhgEdgeSizeThreshold())); | ||
| } | ||
|
|
||
| if ((partitionMethod == Dune::PartitionMethod::metis) && |
Member
Author
There was a problem hiding this comment.
could be else if
Good point. I've pushed an update to that effect.
This commit introduces a new hidden runtime parameter,
ZoltanPhgEdgeSizeThreshold (--zoltan-phg-edge-size-threshold,
double, default value = 0.35)
which maps to Zoltan's low-level control parameter
PHG_EDGE_SIZE_THRESHOLD
that controls which hypergraph edges to omit/discard. We add a new
parameter to 'setupZoltanParameters()' and thread the command line
parameter through as an argument to this function.
This is to enable runtime experimentation with this aspect of the
partitioning algorithm, but end-users should typically not alter the
default value without good reason.
bska
force-pushed
the
expose-zoltan-phg-edge-size-param
branch
from
8675685 to
fed4a3b
Compare
Member
Author
|
jenkins build this please |
Member
Author
|
PR approved and build check is green. I'll merge into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new hidden runtime parameter,
which maps to Zoltan's low-level control parameter
that controls which hypergraph edges to omit/discard. We add a new parameter to
setupZoltanParameters()and thread the command line parameter through as an argument to this function.This is to enable runtime experimentation with this aspect of the partitioning algorithm, but end-users should typically not alter the default value without good reason.