Skip to content

Conversation

@rouault
Copy link
Member

@rouault rouault commented Nov 14, 2025

@rouault rouault added funded through GSP Work funded through the GDAL Sponsorship Program backport release/3.12 Backport to 3.12 branch labels Nov 14, 2025
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 71.351% (-0.01%) from 71.365%
when pulling a883381 on rouault:gdal_mdim_convert_fix
into 0f889ce on OSGeo:master.

Copy link
Collaborator

@elpaso elpaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but while checking the function I noticed that the comment mentions a space but uses a comma in the example, which one is correct?

   /** Declares whether, for list type of arguments, several values, space
     * separated, may be specified. That is "--foo=bar,baz".
     * The default is true.
     */
    GDALAlgorithmArgDecl &SetPackedValuesAllowed(bool allowed)

@rouault
Copy link
Member Author

rouault commented Nov 17, 2025

LGTM but while checking the function I noticed that the comment mentions a space but uses a comma in the example, which one is correct?

comma. Fixed

@rouault rouault merged commit 04d53c3 into OSGeo:master Nov 17, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release/3.12 Backport to 3.12 branch funded through GSP Work funded through the GDAL Sponsorship Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants