ComputeMinMax(): speed-up computation in the non-mask case for all non-complex types (but Byte and UInt16 that were already optimized) #13423
+130
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
minmax_speedup
branch
from
276fd2b to
6034df6
Compare
…n-complex types (but Byte and UInt16 that were already optimized) timings wih a SSE2 optimized build: - before: testByte(): 0.306 testInt8(): 5.779 testUInt16(): 0.726 testInt16(): 2.519 testUInt32(): 6.933 testInt32(): 7.537 testUInt64(): 8.140 testInt64(): 7.807 testFloat16(): 12.953 testFloat32(): 6.105 testFloat64(): 6.525 - after testByte(): 0.308 testInt8(): 0.440 testUInt16(): 0.710 testInt16(): 0.897 testUInt32(): 1.986 testInt32(): 1.826 testUInt64(): 6.004 testInt64(): 5.641 testFloat16(): 2.120 testFloat32(): 1.811 testFloat64(): 3.571
rouault
force-pushed
the
minmax_speedup
branch
from
6034df6 to
aa8708c
Compare
Contributor
|
are the timings swapped? The before are less than the after. |
Member
Author
did you look at the corrected version in github UI (the original one at submission time of the PR was indeed swap) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
timings wih a SSE2 optimized build:
before:
testByte(): 0.306
testInt8(): 5.779
testUInt16(): 0.726
testInt16(): 2.519
testUInt32(): 6.933
testInt32(): 7.537
testUInt64(): 8.140
testInt64(): 7.807
testFloat16(): 12.953
testFloat32(): 6.105
testFloat64(): 6.525
after
testByte(): 0.308
testInt8(): 0.440
testUInt16(): 0.710
testInt16(): 0.897
testUInt32(): 1.986
testInt32(): 1.826
testUInt64(): 6.004
testInt64(): 5.641
testFloat16(): 2.120
testFloat32(): 1.811
testFloat64(): 3.571