r.geomorphon: Rewrite with parson and add json test#7122
Open
saket0187 wants to merge 2 commits intoOSGeo:mainfrom
Open
r.geomorphon: Rewrite with parson and add json test#7122saket0187 wants to merge 2 commits intoOSGeo:mainfrom
saket0187 wants to merge 2 commits intoOSGeo:mainfrom
Conversation
github-actions
bot
added
raster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #6970
I have tried to write this in a cleaner way covering all edge cases. I have also added one test with nested loops to check each key-value pair (with floating-point handling). However, if it looks like too much, we can just use assertEqual. I have removed a few keys like timestamp and generator from expected output as they might cause problems.
Let me know if any changes are needed from my side or if tests need to be modified (or if expected values need to be simplified).