Skip to content

firefox: update to 140ESR and 141, whinlatter #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2025

Conversation

OldManYellsAtCloud
Copy link
Collaborator

This is a bit busier PR than usual:

  1. Added whinlatter compatibility.
  • clang-layer is now only required for pre-whinlatter versions.
  • This brought to the surface that wasi-sdk is not cmake4 compatible. For now I have added a patch to alleviate this issue. I have started to update wasi-sdk a few times, this should give more motivation to bring it through.
  • It also brought up a small difference between clang in oe-core and meta-clang: meta-clang has -Qunused-arguments added to CCARGS by default, which is missing from oe-core (and it fails the configuration for 32-bit arm targets). I have added a small patch to compensate this in Firefox. Still checking if there is anything that is affected in meta-oe and oe-core by this, so it might worth to submit a patch to oe-core, or we should just live with this.
  • Similar to what was discussed in layer.conf: Update to whinlatter (5.3) layer/release series #897, I have added an include in layer.conf that sets the required S for some recipes that need different one in whinlatter and pre-whinlatter. Initially I planned to include it conditionally, depending on the value of LAYERSERIES_CORENAMES - however it seems that require and include directives are processed before this variable would get a value, so I couldn't rely on this, it is always empty at the time when the includes are processed. So the folders are now set both pre- and post-whinlatter, and they are set based on the current version.
  • (plus whatever comes up during the workflow run)
  1. Dropped the v128 ESR series, and switched to the new ESR series, v140.

  2. Updated the regular, latest release from 140 to 141.

  • Since the ESR and latest versions are so close to each other, there is a lot of overlapping between the recipes, so I have unified the recipes and the patches trying to avoid duplications.

@jcalvinowens Unfortunately I am running out of storage space, and unable to keep the old master build artifacts further around, had to do the upgrade. I have added you as a co-author to the whinlatter upgrade. Hope you don't mind.

OldManYellsAtCloud and others added 3 commits July 22, 2025 15:33
- meta-clang is only a requirement for pre-whinlatter versions
- add a config fragment to specify the correct S variable for cbindgen
  and wasi-sdk-native, as they need different values in whinlatter and
  pre-whinlatter versions
- Firefox recipe specifies the AS variable to be used during compilation,
  however due to a change in whinlatter such changes need to be done inside
  tasks, otherwise the default toolchain settings overwrite these due to
  deferred inheritance. Move the AS specification into tasks.

Co-authored-by: Calvin Owens <[email protected]>
Signed-off-by: Gyorgy Sarvari <[email protected]>
v128 series is running out - though there is still one more release now (128.13.0), that is
the last one. Get ahead and switch to the new series.

Signed-off-by: Gyorgy Sarvari <[email protected]>
Also unify the recipes with the ESR version, since there was an ESR version
update, there are a lot of common things across the recipes now - move the common
things to inc, and use only one patch where both versions use the same patch.

Signed-off-by: Gyorgy Sarvari <[email protected]>
Copy link
Collaborator

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OldManYellsAtCloud
Copy link
Collaborator Author

During testing it looks like there were some intermittent infrastructure problems with example.com (used for sanity checks) - I also saw the same issues on my main machine. However while that problem was present, I also noticed that the test process itself didn't fail...

I fixed the tests (hopefully), however it also needed me to rebuild all the images. Though it should only take 2-3 hours, since FF itself doesn't need rebuilding.

@jcalvinowens
Copy link
Contributor

Hope you don't mind.

No problem at all, thanks for finishing it!

@OldManYellsAtCloud
Copy link
Collaborator Author

Phew, finally the workflows has finished, successfully.

I had some troubles still with example.com - google DNS returns multiple akamai IPs, randomly, but it looks like that half of them is unresponsive currently.
At this point I though that I could just set example.com to a static working IP in my own DNS, and use that DNS for testing... which is what I ended up with, but it also took some tries to make qemu use it.

Anyway... it seems to be done now, and unless anyone would like to have something changes, it is ready from my end.

@kraj kraj merged commit 92c6673 into OSSystems:master Jul 25, 2025
960 of 1686 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants