Skip to content

Conversation

sk3l10x1ng
Copy link
Collaborator

closes #3000

@sk3l10x1ng
Copy link
Collaborator Author

@cpholguera please check

@cpholguera cpholguera requested review from Copilot and serek8 August 30, 2025 07:59
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ports MASTG-TEST-0034 (Testing Object Persistence) to a new version MASTG-TEST-0287 (Unwanted Object Deserialization Using Serializable) as part of MASTG V2 migration. The original test is marked as deprecated and replaced with an updated version that focuses specifically on insecure deserialization vulnerabilities in Android applications.

Key changes:

  • Deprecates the original MASTG-TEST-0034 with proper metadata linking to the new version
  • Creates new test MASTG-TEST-0287 with updated content focusing on deserialization security issues
  • Adds comprehensive demo materials including Kotlin/Java code samples and semgrep rules

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

File Description
tests/android/MASVS-CODE/MASTG-TEST-0034.md Adds deprecation metadata linking to new test version
tests-beta/android/MASVS-CODE/MASTG-TEST-0287.md New test definition focusing on insecure deserialization vulnerabilities
rules/mastg-android-object-deserialization.yml Semgrep rule to detect ObjectInputStream.readObject() usage patterns
demos/android/MASVS-CODE/MASTG-DEMO-0061/ Complete demo package with vulnerable code samples, analysis tools, and expected outputs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- java
metadata:
summary: This rule looks for use of Object Serialization
message: "[MASVS-CODE-4] The application make use of Object deserialization in the code."
Copy link

Copilot AI Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar error: 'make use of' should be 'makes use of' to agree with the singular subject 'application'.

Suggested change
message: "[MASVS-CODE-4] The application make use of Object deserialization in the code."
message: "[MASVS-CODE-4] The application makes use of Object deserialization in the code."

Copilot uses AI. Check for mistakes.


### Observation

The output file shows usages of the object persistence in the code.
Copy link

Copilot AI Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'object persistence' is inconsistent with the test's focus on 'object deserialization'. Should be 'object deserialization' to match the test context.

Suggested change
The output file shows usages of the object persistence in the code.
The output file shows usages of object deserialization in the code.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MASTG v1->v2 MASTG-TEST-0034: Testing Object Persistence (android)

1 participant