-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Update objection info box & state #3493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixed: DeprecationWarning: The command 'explore' is deprecated. Use 'objection start' instead of 'objection explore'
Fixed: DeprecationWarning: The command 'explore' is deprecated. Use 'objection start' instead of 'objection explore'
Thanks for adding. People who just install the "latest" objection version 1.11.0 via pip (and not install manually via main branch) will only be able to use I would suggest we wait to merge this PR till a new release is being published and the |
Uh good catch @sushi2k - marked it as blocked |
@Diolor How about we update the objection techniques to include a remark about the current state of objection, and that the techniques and commands are meant for the latest version from the github until v2 is released. When v2 is released, we will remove the notification and update all the commands (including the internal objection commands, which have also been changed a bit). That way we can also close this PR :) I can do it, or you can do it yourself in this PR if you want. |
Let's do that @TheDauntless. :) Could you please take a look at the 4 pages I have touched with my PR and validate if anything else is worth mentioning in those notes aside from the explore/start command change? You might have a more solid understanding of current objection's state than I do. I will change this PR to the notes style in the meantime Update: I drafted the info box |
Co-authored-by: Jeroen Beckers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! :)
Fixed:
DeprecationWarning: The command 'explore' is deprecated. Use 'objection start' instead of 'objection explore'