add ability to manually trigger a workflow + run only on PR and master push#317
Open
atsju wants to merge 2 commits into
Open
add ability to manually trigger a workflow + run only on PR and master push#317atsju wants to merge 2 commits into
atsju wants to merge 2 commits into
Conversation
atsju
changed the title
Hish15
reviewed
Mar 13, 2023
Hish15
left a comment
Hish15
left a comment
Collaborator
There was a problem hiding this comment.
You pushed 2 commits intead of one here
| cmake_minimum_required(VERSION 3.16) | ||
| set(CMAKE_TOOLCHAIN_FILE ${CMAKE_CURRENT_SOURCE_DIR}/../../cmake/stm32_gcc.cmake) | ||
|
|
||
| set(STM32_CUBE_F4_PATH "C:\\GIT\\STM32CubeF4") |
Collaborator
There was a problem hiding this comment.
Use the stm32_fetch_cube(F4) function, in the if stm32_fetch_cube(F4) instead.
Collaborator
Author
There was a problem hiding this comment.
This was not supposed to be pushed. It slipped though on commit
Collaborator
|
@atsju, let's make the changes to merge this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will also help find if #315 fails or master