Skip to content

fix: cherry-pick PR #15695 — replace 33 missing NLS keys causing blank wizard options#15703

Open
Copilot wants to merge 3 commits intodevfrom
copilot/cherry-pick-fix-replace-missing-nls-keys
Open

fix: cherry-pick PR #15695 — replace 33 missing NLS keys causing blank wizard options#15703
Copilot wants to merge 3 commits intodevfrom
copilot/cherry-pick-fix-replace-missing-nls-keys

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

After the JSON-driven wizard migration, many core.* NLS keys were deleted from fx-core/resource/package.nls.json and replaced with template.* keys in the templates resource. TypeScript code paths (VS platform, CLI, Add Action flow) still referenced the deleted keys, causing getLocalizedString() to return empty strings — most visibly, the Add Action → MCP option appeared as a blank clickable item.

Changes

  • constants.ts — Replace core.createProjectQuestion.mcpForDa.{label,detail}template.createProjectQuestion.mcpForDa.*; replace 6 RAG source keys → template.teams.rag.source.*; add Platform import; exclude MCP option from ActionStartOptions.all() on VSCode platform
  • create.ts — Replace core.*customCopilotRag.placeholdertemplate.teams.rag.source.placeholder
  • CapabilityOptions.ts — Replace 18 core.* keys across CustomEngineAgentOptions, TeamsAgentCapabilityOptions, and CustomCopilotRagOptions with their template.* equivalents
  • teamsProjectTypeNode.ts — Replace RAG title and placeholder keys with template.* equivalents
  • package.nls.json — Add 4 genuinely missing keys: error.generator.UnknownPolicy, core.createProjectQuestion.option.description.previewOnWindow, core.createProjectQuestion.oneDriveSharePointItem.confirm, driver.typeSpec.compile.description
  • question.test.ts — Add ActionStartOptions unit tests covering VSCode/CLI platform behavior and staticAll()

Copilot AI changed the title [WIP] Cherry-pick fix for missing NLS keys to other branches fix: cherry-pick PR #15695 — replace 33 missing NLS keys causing blank wizard options Apr 14, 2026
Copilot finished work on behalf of qfai April 14, 2026 06:21
Copilot AI requested a review from qfai April 14, 2026 06:21
@qfai qfai marked this pull request as ready for review April 14, 2026 08:10
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.00%. Comparing base (3d0c608) to head (e48d7c8).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##              dev   #15703    +/-   ##
========================================
  Coverage   92.99%   93.00%            
========================================
  Files         623      623            
  Lines       38538    38540     +2     
  Branches     6973     7137   +164     
========================================
+ Hits        35839    35844     +5     
+ Misses       1959     1957     -2     
+ Partials      740      739     -1     
Files with missing lines Coverage Δ
packages/fx-core/src/question/constants.ts 77.51% <100.00%> (+2.06%) ⬆️
packages/fx-core/src/question/create.ts 78.04% <ø> (ø)
...ore/src/question/scaffold/vsc/CapabilityOptions.ts 81.69% <ø> (ø)
.../src/question/scaffold/vsc/teamsProjectTypeNode.ts 97.10% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cherry-pick] PR #15695 needs to be synchronized to other branches

2 participants