fix: cherry-pick PR #15695 — replace 33 missing NLS keys causing blank wizard options#15703
Open
fix: cherry-pick PR #15695 — replace 33 missing NLS keys causing blank wizard options#15703
Conversation
2 tasks
…ck from PR #15695) Agent-Logs-Url: https://github.com/OfficeDev/microsoft-365-agents-toolkit/sessions/8363e613-4621-44d4-a97f-3a6b2f69af4a Co-authored-by: qfai <9050812+qfai@users.noreply.github.com>
Agent-Logs-Url: https://github.com/OfficeDev/microsoft-365-agents-toolkit/sessions/8363e613-4621-44d4-a97f-3a6b2f69af4a Co-authored-by: qfai <9050812+qfai@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Cherry-pick fix for missing NLS keys to other branches
fix: cherry-pick PR #15695 — replace 33 missing NLS keys causing blank wizard options
Apr 14, 2026
qfai
approved these changes
Apr 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #15703 +/- ##
========================================
Coverage 92.99% 93.00%
========================================
Files 623 623
Lines 38538 38540 +2
Branches 6973 7137 +164
========================================
+ Hits 35839 35844 +5
+ Misses 1959 1957 -2
+ Partials 740 739 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the JSON-driven wizard migration, many
core.*NLS keys were deleted fromfx-core/resource/package.nls.jsonand replaced withtemplate.*keys in the templates resource. TypeScript code paths (VS platform, CLI, Add Action flow) still referenced the deleted keys, causinggetLocalizedString()to return empty strings — most visibly, the Add Action → MCP option appeared as a blank clickable item.Changes
constants.ts— Replacecore.createProjectQuestion.mcpForDa.{label,detail}→template.createProjectQuestion.mcpForDa.*; replace 6 RAG source keys →template.teams.rag.source.*; addPlatformimport; exclude MCP option fromActionStartOptions.all()on VSCode platformcreate.ts— Replacecore.*customCopilotRag.placeholder→template.teams.rag.source.placeholderCapabilityOptions.ts— Replace 18core.*keys acrossCustomEngineAgentOptions,TeamsAgentCapabilityOptions, andCustomCopilotRagOptionswith theirtemplate.*equivalentsteamsProjectTypeNode.ts— Replace RAG title and placeholder keys withtemplate.*equivalentspackage.nls.json— Add 4 genuinely missing keys:error.generator.UnknownPolicy,core.createProjectQuestion.option.description.previewOnWindow,core.createProjectQuestion.oneDriveSharePointItem.confirm,driver.typeSpec.compile.descriptionquestion.test.ts— AddActionStartOptionsunit tests covering VSCode/CLI platform behavior andstaticAll()