Skip to content

Conversation

@ToddTaylor
Copy link

Removed Microsoft.VisualStudio.Shell.11.0 as a prerequisite as this was causing the install to fail in VS2019. Updated upper excluded version limits to 17.0, which is whatever version of Visual Studio that will come after VS2019.

ToddTaylor and others added 2 commits April 18, 2019 11:05
@hansmbakker
Copy link

If you deleted Microsoft.VisualStudio.Shell.11.0, shouldn't it be deleted from the lib folder as well?

</None>
<None Include="Templates\XmlGenerator.tt">
<Generator>TextTemplatingFilePreprocessor</Generator>
<LastGenOutput>XmlGenerator1.cs</LastGenOutput>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line may be unneeded

<SpecificVersion>False</SpecificVersion>
<HintPath>..\lib\Microsoft.VisualStudio.Shell.11.0.dll</HintPath>
</Reference>
<Reference Include="Microsoft.VisualStudio.Shell.15.0, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference can be better consumed from a NuGet package:
https://www.nuget.org/packages/Microsoft.VisualStudio.Shell.15.0/

@BigHoss
Copy link

BigHoss commented Apr 25, 2019

Maybe you can try the MetaPackage from mads

@cilerler
Copy link

cilerler commented Jun 2, 2019

Would you please merge this in so that we can install it

@OmarElabd OmarElabd self-requested a review July 11, 2019 20:46
@cilerler
Copy link

cilerler commented Aug 7, 2019

@OmarElabd bitmoji

@timramone
Copy link

Found installed product - Visual Studio Enterprise 2019
VSIXInstaller.NoApplicableSKUsException: This extension is not installable on any currently installed products.

@OmarElabd
What about merging that? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants