Use Arc all the way down #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 31, 2025
| @@ -734,18 +734,13 @@ impl SessionState { | |||
| } | |||
|
|
|||
| /// return the configuration options | |||
| pub fn config_options(&self) -> &ConfigOptions { | |||
| pub fn config_options(&self) -> &Arc<ConfigOptions> { | |||
There was a problem hiding this comment.
The major idea is to return &Arc rather and then use that directly
alamb
commented
Jul 31, 2025
| @@ -85,11 +85,9 @@ unsafe extern "C" fn release_fn_wrapper(config: &mut FFI_SessionConfig) { | |||
|
|
|||
| unsafe extern "C" fn clone_fn_wrapper(config: &FFI_SessionConfig) -> FFI_SessionConfig { | |||
| let old_private_data = config.private_data as *mut SessionConfigPrivateData; | |||
| let old_config = &(*old_private_data).config; | |||
| let old_config = Arc::clone(&(*old_private_data).config); | |||
There was a problem hiding this comment.
here is a good example of where it caught a deep copy of the config options which isn't necessary -- instead we can just clone the arc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arc<ConfigOptions>toScalarFunctionArgs, don't copyConfigOptionson each query apache/datafusion#16970It shows what is needed if we switch to using
&Arc<ConfigOptions>in most placesIt is technically a larger API change but I think it is eaiser to use and guides people to the correct usage