Skip to content

Alisha - feature : implementation of bidding page overview backend#1729

Open
alishawalunj wants to merge 4 commits intodevelopmentfrom
alisha-bidding-page-overview
Open

Alisha - feature : implementation of bidding page overview backend#1729
alishawalunj wants to merge 4 commits intodevelopmentfrom
alisha-bidding-page-overview

Conversation

@alishawalunj
Copy link
Copy Markdown
Contributor

Description

64D630AE-E0B4-4AFF-9647-0F33518D18E2

Related PRS (if any):

This backend PR is related to the #4073 frontend PR.

Main Changes Explained

  • Updated the getBidOverview endpoint to fetch the following data:

    • Images of the listing
    • Amenities for the property and village
    • Title and description
    • Current bid amount
  • Updated the placeBid endpoint to create a record in the bid collection and generate notifications:

    • Default: Successful bid placed
    • Highest bid: Congratulations message for placing the highest bid

How to test:

  1. check into current branch

  2. do npm install and ... to run this PR locally

  3. Clear site data/cache

  4. log as admin user

  5. Test the following endpoints in Postman to verify functionality:

    • Get bid overview for a listing (GET)

      http://localhost:4500/api/lb/bidoverview/68c5e69e7b6edc12ba7402cc
      
    • Submit a bid and generate notifications (POST)

      http://localhost:4500/api/lb/bidoverview/placeBid/681fdf349b28a081622ba779
      

      Request Body:

      {
        "user_id": "6415352c7de88c396c3bf646",
        "property_id": "681fdf349b28a081622ba779",
        "bid_amount": 89,
        "start_date": "2025-11-15T00:00:00.000Z",
        "end_date": "2025-12-20T00:00:00.000Z"
      }
  6. Verify notifications by placing once low and high bid amount.

  7. For additional listingIds to test, refer to the listings collection in the database.

  8. Make sure to add token in Headers for Authorization.

Screenshots or videos of changes:

Token Generation

A93F87B3-D258-4A00-B642-C6556445EF11

Endpoints to be tested

836DF9F0-75A1-47F7-98D5-4307436AF823

82448322-BBC3-42A6-931F-7980CCFC6F60

Copy link
Copy Markdown

@aditya2512 aditya2512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR delivers an essential backend upgrade for the property bidding page, introducing comprehensive enhancements to both the bid overview and bid placement workflows. The redesigned getBidOverview endpoint now aggregates and provides all necessary data including listing images, property and village amenities, and current bid status offering a rich API layer for the frontend to present a feature-complete bidding experience. The updated placeBid endpoint not only registers bids with robust validation but also coordinates new notification flows for bidders, highest bid achievements, and alerting outbid users, making the entire process more transparent and user-friendly.

However, before merging, it’s critical to address the current CI build failure to ensure overall application stability. Please also review the impact of the structural and dependency file changes for consistency. Going forward, I recommend complementing these implementation changes with concise API documentation covering endpoint payloads, responses, and expected notification scenarios, which will help QA and frontend integration. Once CI passes and documentation is in place, this update will provide a significant boost to the platform's bidding system.

@alishawalunj alishawalunj force-pushed the alisha-bidding-page-overview branch from c8c49ce to 9282572 Compare September 27, 2025 21:22
@alishawalunj alishawalunj force-pushed the alisha-bidding-page-overview branch from 9282572 to 7109b45 Compare January 31, 2026 21:37
@alishawalunj alishawalunj force-pushed the alisha-bidding-page-overview branch from 7109b45 to e43553e Compare April 12, 2026 21:29
@alishawalunj alishawalunj added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Apr 13, 2026
@alishawalunj alishawalunj force-pushed the alisha-bidding-page-overview branch from e43553e to f6daf9b Compare April 13, 2026 02:54
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants