Yu Yan taking over for Ujjwal - feat: Resolved Merge Conflicts and added reasons array in infringements in user profile#1817
Closed
ujjwalbPipKcK wants to merge 1 commit intodevelopmentfrom
Conversation
one-community
added
the
High Priority - Please Review First
Anusha-Gali
requested changes
Dec 17, 2025
Anusha-Gali
left a comment
Anusha-Gali
left a comment
There was a problem hiding this comment.
Hi Ujjwal,
I tried testing your PR but in the API response it doesn't specify the various reasons and only mentions "other", same with mongoDb.
|
I've tested your PR, in mongoDB, no reasons populated. "other" is the only reason I can see. |
one-community
changed the title
yany960
pushed a commit
that referenced
this pull request
Mar 16, 2026
- Add reasons field to infringement schema with enum validation - Supported values: 'time not met', 'missing summary', 'missed video call', 'late reporting', 'other' - Default value: ['other'] - Process reasons array in addInfringements controller: - Normalize to lowercase - Deduplicate values - Filter valid enum values only - Default to ['other'] if empty - Maintain backward compatibility with existing reason field - Resolves merge conflicts from PR #1686 and #1817
Member
|
Redone with this PR: #2106 |
1 similar comment
Member
|
Redone with this PR: #2106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include the exact bug/functionality description and a summary of the changes/ related issues. Please also include any other relevant motivation and context:
Fixes # (PRIORITY HIGH)
Related PRS (if any):
PR 1686
Main changes explained:
Added functionality to easily parse reasons for Blue Squares using a reasons array. Added the reasons a
How to test:
npm run buildandnpm startto run this PR locallyapi/userProfile/:userId/addInfringementto add an infringementScreenshots or videos of changes:
2025-08-29.18-57-46.mp4