Sohail: HGN Questionnaire Dashboard: Community Members (Filtered Members View)

[sohailuddinsyed]

Description

Task: HGN Questionnaire Dashboard: Community Members (Filtered Members View)

Route: /hgnhelp/community
Related PR: PR 4214 -> 4503
Purpose: Displays community members with skill-based filtering.
Issue:

• Team members are not displayed after clicking fliters. Shows failed to load members
• Investigate and fix the backend API/endpoint used to retrieve team members (assign new developer if required).

The GET /api/hgnHelp/community endpoint was returning an empty result set whenever skill-based filters were used. Two bugs in communityController.js were identified as the cause:

1. FormResponse.find() was called without .lean(), returning Mongoose documents instead of plain JS objects. Object.entries() on Mongoose subdocuments does not enumerate actual data fields, so extractSkills always produced empty objects, meaning no member ever matched a skill filter.
2. Without proper key guards in extractSkills, internal Mongoose/MongoDB fields (prefixed with $ or _) could surface during enumeration and pollute the skill key list.

Related PRs (if any):

This backend PR is related to the development frontend branch.

Main changes explained:

• Update src/controllers/communityController.js to add .lean() to the FormResponse.find() query so plain JS objects are returned, allowing Object.entries() to correctly enumerate skill fields.
• Update src/controllers/communityController.js to add key guards in extractSkills that skip keys starting with $ or _, preventing internal fields from appearing in skill results.
• Move extractSkills outside the .map() callback to avoid redefining the function on every iteration.

How to test:

1. Check out branch fix/community-members-skill-filter
2. Run npm install then start the server
3. Clear site data/cache
4. Log in as an admin user
5. Navigate to /hgnhelp/community
6. Apply one or more skill filters (e.g. React, MongoDB)
7. Verify that matching community members are displayed in the list
8. Verify that with no filters applied, all members are still shown
9. Verify that the search and sortOrder query params still work as expected

Screenshots or videos of changes:

Before:

After:

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[HemanthNidamanuru]

Hi Sohail,

I tested this PR locally by following the steps above. Found a couple of issues:

1. When no filters are applied, no members are showing at all. All members should be displayed by default.
2. There is no sort option visible on the page anywhere. The sortOrder query param is mentioned in the test steps but there is no sorting control on the UI.

Could you please take a look at these?

[Anusha-Gali]

Hi Sohail,

I have reviewed your PR locally and as mentioned by other reviewer, unable to see the default list of all members when no filters are selected and no sort order option is visible in frontend nor can any change be seen in Postman response.

[sohailuddinsyed]

@HemanthNidamanuru @Anusha-Gali
Thank you for your reviews. To address your concerns:

• On sortOrder:

sortOrder was pre-existing in the original controller before this PR and was not introduced here. The backend supports it as a query param, but it looks like there is no sort UI on the frontend, it is effectively an unused param sitting in the API. Removing/adding it is out of scope for this bug fix and can be addressed in a separate task on the frontend.

• On no members showing by default:

The backend already handles this correctly. When no skills query param is provided, skillFilters is an empty array and the endpoint returns all members from the HGNFormResponses collection. To confirm, hitting GET /api/hgnHelp/community with no query params should return all members. If nothing is showing on the page with no filters applied, the issue is in the frontend rendering logic, not this backend endpoint, and would need to be investigated in the related frontend PR.

[Anusha-Gali]

Hi Sohail,

Thank you for the update.

[one-community]

Thank you all, merging!

Fixed and approved

[rajanidi1999]

Hi,
I have reviewed your PR locally

[rajanidi1999]

I’ve reviewed your PR, and it has been successfully executed. The implementation works as expected, and the overall structure is clean and well-organized. The feature integrates smoothly with the existing codebase, and the UI components appear consistent and responsive. I didn’t notice any major issues, though you might consider minor refinements for readability and consistency in naming. Overall, great job this is ready to be merged.