Player model - CI - Apply fixes from main #2261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-lobanov/setup-android-tools is no longer working with github CI and it hasn't been updated in 4 years.
This is required for the newer Android command line tools being used now. Also dropped installing gradle, gradlew already handles this.
* See deprecation notice: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ * Let's update all `actions` packages to v4 * The `android-actions/setup-android` is still on release v3
CI was not passing, so this most likely missed in a different PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets CI running on the player-model-main branch again. However there are some odd warnings and a number of tests do not pass, some of these tests may have been broken before hand.
This change is