Skip to content

add: security hardening around webview javaScriptEnabled #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2025
Merged

add: security hardening around webview javaScriptEnabled #2377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e929fed
add: security hardening around webview javaScriptEnabled
jinliu9508 Oct 9, 2025
2398782
add a comment explaining the security measure
jinliu9508 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions ...essages/src/main/java/com/onesignal/inAppMessages/internal/display/impl/WebViewManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.app.Activity
import android.os.Build
import android.view.View
import android.webkit.JavascriptInterface
import android.webkit.WebSettings
import android.webkit.WebView
import com.onesignal.common.AndroidUtils
import com.onesignal.common.ViewUtils
Expand Down Expand Up @@ -299,7 +300,6 @@ internal class WebViewManager(
}
}

@SuppressLint("SetJavaScriptEnabled", "AddJavascriptInterface")
suspend fun setupWebView(
currentActivity: Activity,
base64Message: String,
Expand All @@ -310,7 +310,7 @@ internal class WebViewManager(
webView!!.overScrollMode = View.OVER_SCROLL_NEVER
webView!!.isVerticalScrollBarEnabled = false
webView!!.isHorizontalScrollBarEnabled = false
webView!!.settings.javaScriptEnabled = true
secureSetup(webView!!)

// Setup receiver for page events / data from JS
webView!!.addJavascriptInterface(OSJavaScriptInterface(), JS_OBJ_NAME)
Expand All @@ -329,6 +329,33 @@ internal class WebViewManager(
webView!!.loadData(base64Message, "text/html; charset=utf-8", "base64")
}

/**
* Applies security hardening to the WebView to prevent common vulnerabilities.
*
* Security measures:
* - JavaScript is enabled for IAM functionality but file access is completely blocked
* - Prevents file:// URL access to mitigate local file inclusion attacks
* - Blocks cross-origin access from file URLs to prevent data exfiltration
* - Disables mixed content (HTTP resources on HTTPS pages) to prevent MITM attacks
*
* This configuration protects against:
* 1. Malicious JavaScript accessing local device files
* 2. Cross-site scripting (XSS) attacks via file:// protocol
* 3. Man-in-the-middle attacks via downgraded HTTP content
*
* @SuppressLint is used because JavaScript is required for IAM functionality,
* but we mitigate the risk through strict file access controls.
*/
@SuppressLint("SetJavaScriptEnabled")
fun secureSetup(webView: WebView) =
with(webView.settings) {
javaScriptEnabled = true
allowFileAccess = false
allowFileAccessFromFileURLs = false
allowUniversalAccessFromFileURLs = false
mixedContentMode = WebSettings.MIXED_CONTENT_NEVER_ALLOW
}

// This sets the WebView view port sizes to the max screen sizes so the initialize
// max content height can be calculated.
// A render complete or resize event will fire from JS to tell Java it's height and will then display
Expand Down
Loading