fix: prevent duplicate native handler registrations#1085
Open
sherwinski wants to merge 3 commits intomainfrom
Open
fix: prevent duplicate native handler registrations#1085sherwinski wants to merge 3 commits intomainfrom
sherwinski wants to merge 3 commits intomainfrom
Conversation
Added flags to ensure addEventListener() only registers each native handler once per event type, eliminating unnecessary `cordova.exec` calls. This fix is applied to the InAppMessages, Notifications, User, and PushSubscription namespaces.
1003dbe to
782c2d3
Compare
d608ec1 to
9d144c1
Compare
Contributor
Author
|
I'm not sure if this is a realistic concern but thought I'd raise it anyways for discussion. |
9d144c1 to
2bf66ce
Compare
f9ef46e to
80ffffa
Compare
3c70db9 to
0997dcf
Compare
e9bf279 to
234f334
Compare
93f63aa to
4ddcfad
Compare
9ef18ce to
59b496d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Added flags to ensure
addEventListener()only registers each native handler once per event type, eliminating unnecessarycordova.execcalls.Details
Motivation
I noticed that we may be creating too many native handlers, once per each invocation of
addEventListener(). This could cause a potential memory leak in the consuming applications.Scope
Any
addEventListenerfunction across theInAppMessages,Notifications,User, andPushSubscriptionnamespaces.Testing
Unit testing
One tested added that ensures that
cordova.execis only called once, no matter how many event listeners are added.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is