chore: rename sdk-actions to sdk-shared#1155
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
| jobs: | ||
| call: | ||
| uses: OneSignal/sdk-actions/.github/workflows/wrapper-js-ci.yml@main | ||
| uses: OneSignal/sdk-shared/.github/workflows/wrapper-js-ci.yml@main |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
In general, to fix this issue you should explicitly define a permissions block for the workflow (at the top level) and/or for the specific job so that the GITHUB_TOKEN has only the minimal scopes required. When a workflow is primarily running checks and reuses another workflow, a safe minimal default is typically contents: read (and any other scopes required by the called workflow, if known). Since we must avoid changing functionality and we do not know of any write operations from this snippet, the safest non-breaking improvement is to define a read-only baseline at the workflow-root level so it applies to the reused workflow job.
Concretely, in .github/workflows/ci.yml, insert a permissions block between the on: section and the concurrency: section. Set contents: read, which is equivalent to the read-only default and therefore should not break existing behavior for a CI/checks workflow while satisfying the CodeQL requirement and documenting the intended minimal permissions. No imports or other definitions are needed; this is a pure YAML configuration change.
| @@ -4,6 +4,9 @@ | ||
| branches: | ||
| - '**' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Summary
Update all GitHub workflow references from
sdk-actionstosdk-sharedto reflect the repo rename.Made with Cursor
This change is