Skip to content

Task: add Compose smoke test#254

Merged
smithaldon1 merged 1 commit into
mainfrom
task/issue-241-compose-smoke-test
May 27, 2026
Merged

Task: add Compose smoke test#254
smithaldon1 merged 1 commit into
mainfrom
task/issue-241-compose-smoke-test

Conversation

@smithaldon1

Copy link
Copy Markdown
Member

Summary

  • Add make compose-smoke backed by factory_api.compose_smoke to start or verify the FIP Compose stack against a separately running Demo-Factory stack.
  • Verify expected Compose services, API health/runtime metadata, connector-ingested FactoryEvents, current connector emitted-event logs, readable Process Sentinel state, and Workbench rendering.
  • Make FIP API/web host ports configurable and run the smoke path on 18000/13000 so it can coexist with Demo-Factory 8000/3000 services.

Closes #241

Test Evidence

  • .venv/bin/python -m pytest services/api/tests/test_compose_smoke.py services/simulator/tests/test_docker_compose_runtime_docs.py: 14 passed
  • make lint: passed
  • make typecheck: passed
  • cd apps/web && npm test: 19 passed
  • make test: 291 passed, 4 skipped
  • docker compose -f infra/docker/docker-compose.yml config: passed
  • cd ../Demo-Factory && docker compose up -d --build: passed
  • make compose-smoke: passed; services=5, events=260, detections=0, web_status=200
  • docker compose -f infra/docker/docker-compose.yml down: passed
  • cd ../Demo-Factory && docker compose down: passed

Docs Impact

  • Updated README, Workbench README, docs/runtime/DOCKER_COMPOSE.md, docs/TESTING.md, and docs/LEARNING_LOG.md with the smoke command, ports, checks, and recovery guidance.
  • Updated .env.example with configurable FIP host port and public API URL variables.

Follow-up Work

  • Consider adding CI-gated Compose smoke coverage once the CI runner has Docker and Demo-Factory fixture availability.

@smithaldon1 smithaldon1 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved for merge

@smithaldon1 smithaldon1 merged commit e7b2676 into main May 27, 2026
3 checks passed
@smithaldon1 smithaldon1 deleted the task/issue-241-compose-smoke-test branch May 27, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task: Add Compose smoke test

1 participant