[codex] Enable Claude auto review for fork PRs#251
Conversation
karmachoi
force-pushed
the
codex/claude-all-pr-review
branch
from
91d40fc to
70a663f
Compare
karmachoi
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70a663f0fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - name: Claude PR Review | ||
| id: claude_review | ||
| continue-on-error: true |
There was a problem hiding this comment.
When this new pull_request_target path is triggered by an external fork author who lacks write access, anthropics/claude-code-action rejects the run by default unless non-write users are explicitly allowed (with the appropriate token input). Because the fork guard was removed but no allowed_non_write_users/token configuration was added, those fork PRs will just hit this now-advisory failure path and no automatic review will be posted, which defeats the stated fork-review behavior.
Useful? React with 👍 / 👎.
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.pull_request.base.sha }} |
There was a problem hiding this comment.
For same-repo or otherwise allowed PRs, this now pins the workspace to the trusted base commit, but the action is running in direct-prompt agent mode and this workflow does not provide a PR-head checkout or gh pr diff/view tools for Claude to inspect the proposed changes. In that context Claude can only read the pre-PR base tree, so automatic reviews will miss or misreport issues in the actual diff.
Useful? React with 👍 / 👎.
| uses: anthropics/claude-code-action@v1 | ||
| with: | ||
| claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} | ||
| prompt: | |
There was a problem hiding this comment.
On pull_request_target runs that make it past authorization, supplying a direct prompt makes anthropics/claude-code-action handle the PR in agent mode, which does not create the normal PR review/tracking comment unless commenting tools or another posting workaround are explicitly configured. As written, a successful automatic review can finish only in the workflow output instead of leaving the non-blocking PR comment requested here, so authors and reviewers will not see the review on the PR.
Useful? React with 👍 / 👎.
1 participant
Summary
pull_request_targetso fork PRs are reviewed tooNotes
The upstream repository already has
CLAUDE_CODE_OAUTH_TOKENconfigured. This PR does not require adding a new secret.Codex automatic review is separate from this workflow. Native Codex reviews are configured in Codex settings and can run automatically without adding an
OPENAI_API_KEYGitHub Actions secret.@codex reviewremains the manual trigger for a one-off Codex review.Validation
.github/workflows/claude.ymlwith RubyYAML.load_filegit diff --checkCLAUDE_CODE_OAUTH_TOKENin GitHub Actions secrets