Repository navigation
Pin graphql-core below 3.3 (main linter red) - #2425
Merged
Merged
Conversation
graphql-core was only a transitive dependency of strawberry-graphql (which allows <3.4), so fresh installs resolved 3.3.0. 3.3 reworked graphql.execution.collect_fields (new signature, CollectedFields NamedTuple return), breaking config/graphql/automation.py::_check at runtime and failing mypy on main. Pin to 3.2.x until a deliberate port.
|
Review: LGTM.
Suggestions, none blocking:
|
The mypy hook resolves additional_dependencies independently of the requirements files, so it still pulled graphql-core 3.3. Also sync its strawberry-graphql pin to base.txt (0.323.2 -> 0.327.7).
|
Review: LGTM. Small, well-scoped fix.
Non-blocking notes:
Please do open the follow-up issue for the 3.3 port so the upper bound doesn't linger. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Backend CI on
mainis red (linter/mypy), and so is every PR rebased on it:graphql-coreis not pinned. It arrives only throughstrawberry-graphql==0.327.7, which declaresgraphql-core>=3.2.0,<3.4.0. graphql-core 3.3.0 has now been released, so fresh installs resolve to it. The last green main run (Sep 24) installed 3.2.12.This is a runtime break as well as a typing error. In 3.3,
graphql.execution.collect_fields(schema, fragments, variable_values, runtime_type, operation)takesFragmentDetailsand anOperationDefinitionNodeand returns aCollectedFieldsNamedTuple.automation.py::_checkpasses a selection set and calls.values()on the result, so the scoped-automation selection check would raise under 3.3.Fix
Pin
graphql-core>=3.2,<3.3inrequirements/base.txt. Moving to 3.3 means porting_checkdeliberately and is left as a follow-up.Unblocks dependabot PRs #2417, #2410, #2407.