Change jackson-databind dependency to not being shipped transitively #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domids
reviewed
Apr 29, 2025
README.md
Outdated
| @@ -25,6 +25,30 @@ The module is compatible with JDK8+ | |||
|
|
|||
| ## Usage | |||
|
|
|||
| Starting from version `2.0.7` the jackson-databind dependency is no longer transitively shipped with this library. Therefore, it needs to be declared explicitly. This enables you to be more flexible in updating the jackson version you are using for your project. | |||
There was a problem hiding this comment.
Minor typo - I think it should be "version 0.2.7" instead of "version 2.0.7" :)
|
I think this is a good idea. This need to be documented when it is merged in the release notes / changelog. |
plumstone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60
This PR is a proposal for a long-term solution for the continuous maintenance of the jackson-databind library.
The user of jackson-databind-nullable will be forced to explicitly declare the dependency on jackson-databind. This gives him full control over the jackson version he uses for his project.
In the past, jackson-databind has been known to have some vulnerabilities.
With this change, the consumer is no longer directly bound to the jackson version that jackson-nullable was built with.
If you have any concerns, please let me know. I welcome any feedback.