Skip to content

Conversation

wexom
Copy link
Contributor

@wexom wexom commented Sep 23, 2025

fix #834

changed different line separators in AsciiDocRender.java to make it consistent and to fix tests on Windows 11

@DrSatyr DrSatyr requested a review from Copilot September 24, 2025 10:24
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #834 by standardizing line separators in AsciiDocRender.java to use Unix-style newlines ("\n") instead of platform-specific line separators, ensuring consistent behavior across different operating systems and fixing test failures on Windows 11.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DrSatyr
Copy link
Collaborator

DrSatyr commented Sep 24, 2025

@wexom, thanks for your contribution!

I would suggest using System.lineSeparator() in all places in AsciiDocRender.java instead of '\n'. This will support all platforms.

AsciidocRenderTest.java uses strings with '\n' as an expected outcome. So, please try to use 'isEqualToNormalizingNewlines' instead of pure 'isEqualTo' assertion, it should work on any platform then.

… fixed tests with isEqualToNormalizingNewlines
@wexom
Copy link
Contributor Author

wexom commented Sep 24, 2025

PR updated based on the comments from @DrSatyr, ready for next round.

@DrSatyr
Copy link
Collaborator

DrSatyr commented Sep 25, 2025

@wexom looks great. Thank you for your contribution!

@DrSatyr DrSatyr merged commit 3d2280e into OpenAPITools:master Sep 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests from AsciidocRenderTest.java are failing on Windows 11
2 participants