fix for issue 814 #836
Merged
fix for issue 814 #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #814 by improving the validation of array examples in OpenAPI specifications. The fix properly handles array comparison for primitive types by using deep equality checks instead of relying on Objects.equals() alone.
- Adds specialized array comparison logic for changed examples
- Adds test case to verify CSV media type response examples with binary format
- Refactors example validation to handle arrays of primitive types correctly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ChangedExample.java | Implements array-specific comparison logic using reflection and deep equality |
| ConsoleRenderTest.java | Adds test to verify no differences shown for identical CSV binary examples |
| issue-828-binary-example-for-csv-media-type.yaml | Test resource file for CSV media type validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
core/src/main/java/org/openapitools/openapidiff/core/model/ChangedExample.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/openapitools/openapidiff/core/output/ConsoleRenderTest.java
Outdated
Show resolved
Hide resolved
DrSatyr
reviewed
Sep 24, 2025
core/src/main/java/org/openapitools/openapidiff/core/model/ChangedExample.java
Show resolved
Hide resolved
core/src/main/java/org/openapitools/openapidiff/core/model/ChangedExample.java
Outdated
Show resolved
Hide resolved
core/src/test/java/org/openapitools/openapidiff/core/output/ConsoleRenderTest.java
Outdated
Show resolved
Hide resolved
…ays of primitive types changed equal validation for changed example to properly validate arrays of primitive types
…hangedExamples.java, Fixed suggestion from copilot, grammatical error
formatting fix
wexom
force-pushed
the
bugfix/issue-814-false-positive-diff-change-example-byte-array
branch
from
60f9776 to
77dfb93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #814
changed equal validation for changed example to properly validate arrays of primitive types