Skip to content

Drop Python 3.9 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Drop Python 3.9 #34

wants to merge 5 commits into from

Conversation

eggplants
Copy link
Member

@eggplants eggplants commented Aug 16, 2025

Note

Merge after 31 Oct 2025

fixes: #33

Drop Python 3.9 and use jdk4py as default for portability.

Edit: jdk4py supports only a limited number of architectures, and if it is made mandatory, it will no longer work on Android or Windows on ARM, for example. Therefore, I would like to make it optional again.


After merged,

Copy link

github-actions bot commented Aug 16, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py33972%33, 37–38, 44, 61–64, 68
TOTAL33972% 

Tests Skipped Failures Errors Time
3 0 💤 0 ❌ 0 🔥 2.345s ⏱️

@eggplants eggplants force-pushed the drop-python-3.9 branch 2 times, most recently from 4030c19 to dd2dc7f Compare August 16, 2025 01:15
@eggplants eggplants changed the title Drop python 3.9 Drop Python 3.9 Aug 16, 2025
@eggplants eggplants marked this pull request as ready for review August 16, 2025 01:53
@eggplants eggplants requested a review from Copilot August 16, 2025 01:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR drops Python 3.9 support and makes jdk4py a required dependency instead of optional, improving portability by bundling Java runtime with the package.

  • Removes Python 3.9 support and updates minimum required version to 3.10
  • Makes jdk4py a required dependency instead of optional
  • Simplifies Java runtime detection by removing fallback to system Java

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Updates Python version requirements and makes jdk4py a required dependency
openapi_generator_cli/init.py Removes Java detection fallback logic and imports jdk4py directly
README.md Updates installation instructions to reflect jdk4py as default
.pre-commit-config.yaml Updates pre-commit hook versions
.github/workflows/test.yaml Removes Python 3.9 from test matrix and Java setup step

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@eggplants eggplants requested a review from wing328 August 16, 2025 01:54
@wing328
Copy link
Member

wing328 commented Aug 16, 2025

thanks for the PR

given that python 3.9 is still supported (https://endoflife.date/python, last release in jun 2025)

shall we keep it for another 2 months before dropping its support?

@eggplants eggplants marked this pull request as draft August 16, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.9
2 participants