-
Notifications
You must be signed in to change notification settings - Fork 7
Drop Python 3.9 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Drop Python 3.9 #34
Conversation
4030c19
to
dd2dc7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR drops Python 3.9 support and makes jdk4py a required dependency instead of optional, improving portability by bundling Java runtime with the package.
- Removes Python 3.9 support and updates minimum required version to 3.10
- Makes jdk4py a required dependency instead of optional
- Simplifies Java runtime detection by removing fallback to system Java
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
pyproject.toml | Updates Python version requirements and makes jdk4py a required dependency |
openapi_generator_cli/init.py | Removes Java detection fallback logic and imports jdk4py directly |
README.md | Updates installation instructions to reflect jdk4py as default |
.pre-commit-config.yaml | Updates pre-commit hook versions |
.github/workflows/test.yaml | Removes Python 3.9 from test matrix and Java setup step |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
thanks for the PR given that python 3.9 is still supported (https://endoflife.date/python, last release in jun 2025) shall we keep it for another 2 months before dropping its support? |
7ac7c5d
to
3a5c1fb
Compare
Note
Merge after 31 Oct 2025
fixes: #33
Drop Python 3.9
and use.jdk4py
as default for portabilityEdit:
jdk4py
supports only a limited number of architectures, and if it is made mandatory, it will no longer work on Android or Windows on ARM, for example. Therefore, I would like to make it optional again.After merged,
7.14.0.post0