-
Notifications
You must be signed in to change notification settings - Fork 68
V1.13.16 Updates #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ClutchplateDude
wants to merge
13
commits into
develop
Choose a base branch
from
guiding-fixes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V1.13.16 Updates #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ClutchplateDude
commented
Apr 20, 2025
- Limited refresh rate of InfoDisplay to:
- 30fps when not slewing RA or DEC.
- 5fps when slewing either RA or DEC axis.
- off when slewing both RA and DEC axes.
- Ignore DEC Guide pulses when at DEC limits.
Serial handling was blocking until timeout (1s), which made sub 1s guiding near impossible (!).
# Conflicts: # src/Mount.cpp # src/f_serial.hpp
- Improved Serial command handling (made it less 'blocking'), which should improve general performance - Guiding now updates RA/DEC coordinates - Guide pulses are ignored when tracking is disabled (for example, when at the limits)
# Conflicts: # Changelog.md # Version.h # src/Mount.cpp
Looks like your PR has code that needs to be changed in order to meet our coding standards!
|
julianneswinoga
approved these changes
Apr 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change request
Comment on lines
+3254
to
+3263
int refreshRateHz = 30; | ||
long now = millis(); | ||
if ((slewStatus() & (SLEWING_DEC | SLEWING_RA)) == (SLEWING_DEC | SLEWING_RA)) | ||
{ | ||
return; | ||
} | ||
else if (isSlewingRAorDEC()) | ||
{ | ||
refreshRateHz = 5; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
int refreshRateHz = 30; | |
long now = millis(); | |
if ((slewStatus() & (SLEWING_DEC | SLEWING_RA)) == (SLEWING_DEC | SLEWING_RA)) | |
{ | |
return; | |
} | |
else if (isSlewingRAorDEC()) | |
{ | |
refreshRateHz = 5; | |
} | |
int refreshRateHz = 30; | |
const bool isSlewingRAandDEC = (slewStatus() & (SLEWING_DEC | SLEWING_RA)) == (SLEWING_DEC | SLEWING_RA); | |
if (isSlewingRAandDEC) | |
{ | |
return; // Do not update the display | |
} | |
else if (isSlewingRAorDEC()) | |
{ | |
refreshRateHz = 5; // Update the display slower | |
} | |
const long now = millis(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.