feat: add Khipro compositional input method#49
Open
qomarhsn wants to merge 1 commit into
Open
Conversation
Introduce a third input-method category alongside phonetic and fixed: "compositional", which turns a roman key sequence into Bengali through a deterministic engine. Khipro is the first such layout, driven by an embedded m17n `.mim` spec. - src/compositional/: CompositionalEngine trait, Method impl (tape replay + backspace), and a pure-Rust port of the khipro library's s-expression parser, spec AST, and FSM interpreter (mim/). - config: add LayoutMethod + compositional_suggestion setting; recognize the built-in "khipro" layout name. - context: dispatch to CompositionalMethod via layout_method(). - ffi: riti_config_set_compositional_suggestion (+ riti.h declaration). The first candidate is the exact Khipro composition; dictionary/emoji suggestions follow, as with the fixed method. The candidate-window auxiliary text shows the raw roman keystrokes. Vendored data (data/khipro/), MIT licensed: - bn-khipro.mim (c) 2024 rank_coder - embedded at runtime - khipro-testcases.csv - used only by the #[cfg(test)] conformance test
Member
|
@qomarhsn Hi! Thanks for the pull request! But have you checked the OpenBangla/OpenBangla-Keyboard#426 ticket beforehand? We already have Khipro support in the Okkhor crate. The remaining work was about generating suggestions for Khipro, which I have done initially in the Can you give me the rationale why we should proceed to have a .mim based layout system? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a third input-method category alongside phonetic and fixed: "compositional", which turns a roman key sequence into Bengali through a deterministic engine. Khipro is the first such layout, driven by an embedded m17n
.mimspec.The first candidate is the exact Khipro composition; dictionary/emoji suggestions follow, as with the fixed method. The candidate-window auxiliary text shows the raw roman keystrokes.
Vendored data (data/khipro/), MIT licensed: